fix(dynamic-agents): verify caller context end to end - #2370
fix(dynamic-agents): verify caller context end to end#2370sriaradhyula wants to merge 4 commits into
Conversation
|
✅ No proprietary content detected. This PR is clear for review! |
🧪 CAIPE UI Test Results❌ Tests failed - Please review the logs 🟡 Overall Coverage: 62%📊 Detailed Coverage
✅ Test Suites
📈 Coverage Thresholds
|
ℹ️ Branch is behind
|
Prebuild Artifacts for `ae3b20a` (archived)Prebuild Artifacts for
|
| Artifact | Image | Tag | Status | CI |
|---|---|---|---|---|
| caipe-dynamic-agents | - | - | Failed | CI |
| caipe-ui | - | - | Failed | CI |
These prebuild artifacts will be automatically cleaned up when the PR is closed or merged.
Prebuild Artifacts for `c6a9496` (archived)Prebuild Artifacts for
|
| Artifact | Image | Tag | Status | CI |
|---|---|---|---|---|
| caipe-dynamic-agents | ghcr.io/cnoe-io/prebuild/caipe-dynamic-agents |
fix-dynamic-agents-strict-auth-6 |
Published | CI |
| caipe-ui | ghcr.io/cnoe-io/prebuild/caipe-ui |
fix-dynamic-agents-strict-auth-6 |
Published | CI |
Docker pull commands
docker pull ghcr.io/cnoe-io/prebuild/caipe-dynamic-agents:fix-dynamic-agents-strict-auth-6
docker pull ghcr.io/cnoe-io/prebuild/caipe-ui:fix-dynamic-agents-strict-auth-6Helm Charts
| Chart | Registry | Version | Status | CI |
|---|---|---|---|---|
| ai-platform-engineering | ghcr.io/cnoe-io/prebuild-helm-charts |
0.5.69-dev.2-fix-dynamic-agents-strict-auth-5 |
Published | CI |
Helm install commands
helm upgrade --install ai-platform oci://ghcr.io/cnoe-io/prebuild-helm-charts/ai-platform-engineering --version 0.5.69-dev.2-fix-dynamic-agents-strict-auth-5These prebuild artifacts will be automatically cleaned up when the PR is closed or merged.
Code review findingsI would block merge on the following issues: 1. High: strict bearer authentication can be bypassedIn I reproduced a protected request returning HTTP 200 with 2. High: signature enforcement was not applied to all Dynamic Agents callers
Existing callers still construct the header manually and will receive 401 responses, including: Signing should be centralized and all manual 3. High: the NetworkPolicy blocks autonomous-agentsThe new policy permits only UI and metrics pods, while autonomous-agents connects directly to Dynamic Agents. Because the umbrella values enable this policy, autonomous executions will be denied at the network layer before authentication is attempted. The policy needs an autonomous-agents ingress rule, a configurable additional-caller list, or the caller must be routed through the BFF. 4. Medium: the required HMAC secret fails only at request timeThe new HMAC secret is mandatory, but both umbrella references default to empty. Existing Helm installations can upgrade successfully and then fail at runtime with UI 500 / Dynamic Agents 503 responses. This should be caught during chart rendering or called out as an explicit upgrade requirement. The current CI covers the individual middleware and signing helpers, but it does not exercise these cross-service call paths. |
|
Addressed all four findings in ec088b9:
Validation completed locally:
There are no GitHub review-thread objects on this PR to resolve; the findings were posted as a top-level PR comment. CI is now running against the updated commit. |
Signed-off-by: Sri Aradhyula <sraradhy@cisco.com>
Signed-off-by: Sri Aradhyula <sraradhy@cisco.com>
Signed-off-by: Sri Aradhyula <sraradhy@cisco.com>
ec088b9 to
3ef260d
Compare
Prebuild Artifacts for `3ef260d` (archived)Prebuild Artifacts for
|
| Artifact | Image | Tag | Status | CI |
|---|---|---|---|---|
| caipe-dynamic-agents | - | - | Failed | CI |
| caipe-ui | - | - | Failed | CI |
These prebuild artifacts will be automatically cleaned up when the PR is closed or merged.
Prebuild Artifacts for
|
| Artifact | Image | Tag | Status | CI |
|---|---|---|---|---|
| caipe-autonomous-agents | ghcr.io/cnoe-io/prebuild/caipe-autonomous-agents |
fix-dynamic-agents-strict-auth-5 |
Published | CI |
| caipe-dynamic-agents | ghcr.io/cnoe-io/prebuild/caipe-dynamic-agents |
fix-dynamic-agents-strict-auth-5 |
Published | CI |
| caipe-ui | ghcr.io/cnoe-io/prebuild/caipe-ui |
fix-dynamic-agents-strict-auth-5 |
Published | CI |
Docker pull commands
docker pull ghcr.io/cnoe-io/prebuild/caipe-autonomous-agents:fix-dynamic-agents-strict-auth-5
docker pull ghcr.io/cnoe-io/prebuild/caipe-dynamic-agents:fix-dynamic-agents-strict-auth-5
docker pull ghcr.io/cnoe-io/prebuild/caipe-ui:fix-dynamic-agents-strict-auth-5Helm Charts
| Chart | Registry | Version | Status | CI |
|---|---|---|---|---|
| ai-platform-engineering | ghcr.io/cnoe-io/prebuild-helm-charts |
0.5.69-dev.4-fix-dynamic-agents-strict-auth-4 |
Published | CI |
Helm install commands
helm upgrade --install ai-platform oci://ghcr.io/cnoe-io/prebuild-helm-charts/ai-platform-engineering --version 0.5.69-dev.4-fix-dynamic-agents-strict-auth-4These prebuild artifacts will be automatically cleaned up when the PR is closed or merged.
Description
Complete the Dynamic Agents caller-authentication rollout across the BFF, runtime, Compose, and Helm deployment paths.
Type of Change
Pre-release Helm Charts (Optional)
This PR updates the caipe-ui and dynamic-agents subcharts and adds a Dynamic Agents NetworkPolicy template. The branch uses the repository's prebuild prefix for image validation.
Checklist
Validation