feat(ui): standardize searchable agent pickers - #2403
Draft
sriaradhyula wants to merge 3 commits into
Draft
Conversation
Signed-off-by: Sri Aradhyula <sraradhy@cisco.com>
Signed-off-by: Sri Aradhyula <sraradhy@cisco.com>
Signed-off-by: Sri Aradhyula <sraradhy@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Standardize compact single-agent selection on the shared searchable
AgentPickerand ensure paginated Dynamic Agent catalogs are loaded completely.Root cause
The Webex 1:1 and Conversations screens built picker options from only the first Dynamic Agents API page. Other screens used native or one-off selectors, so search and required-selection behavior were inconsistent.
What changed
AgentPicker.Type of Change
Validation
npm test -- --runInBand src/lib/__tests__/dynamic-agent-list.test.ts src/components/ui/__tests__/agent-picker.test.tsx src/components/admin/rebac/__tests__/WebexSpaceRebacPanel.test.tsx src/components/admin/security/__tests__/AccessExplorerTab.test.tsx— 27 passedRUN_RBAC_REGRESSION=1 npx playwright test e2e/rbac/webex-configure-spaces.spec.ts e2e/rbac/dynamic-agents-conversations-superadmin.spec.ts e2e/rbac/access-explorer.spec.ts --config=playwright.rbac.config.ts— 17 passednpm run lintnpm run buildChecklist