New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AnnotationBear: return precise string/comment info #1038

Open

abh3po wants to merge 2 commits into master from fixannot

Member

abh3po commented Nov 22, 2016

Earlier the return used to be either a tuple of source ranges
of strings/comments now it is a tuple of namedtuples with fields
"start_delimiter_range end_delimiter_range content_range full_range"
of singleline strings/multiline strings/singlieline comments/
multiline comments

gitmate-bot added process/pending review size/L labels

Collaborator

gitmate-bot commented Nov 22, 2016

Thanks for your contribution!

Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.

I have rebased properly. Please see this for a tutorial.
I have gone through the commit guidelines and I've followed them:
I have followed the guidelines for the commit shortlog.
I have followed the guidelines for the commit body.
I have included the issue URL.
I have used the Fixes keyword if the commit fixes a real bug and the Closes keyword if it adds a feature/enhancement. See more here.
I have run all the tests and they all pass. That includes that all CI (below) is green - if GitMate issues appear you will have to amend your commits, pushing new commits on top is not sufficient!

As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!

Collaborator

gitmate-bot commented Nov 22, 2016

Comment on 73c8c9f.

Shortlog of HEAD commit does not match given regex.

GitCommitBear, severity NORMAL, section commit.

Member

Nosferatul commented Nov 22, 2016

return -> Return in head of commit

abh3po force-pushed the fixannot branch from 73c8c9f to e10933f Compare

November 22, 2016 08:28

gitmate-bot added size/XL and removed size/L labels

abh3po force-pushed the fixannot branch from e10933f to 46f6489 Compare

November 22, 2016 14:02

gitmate-bot added size/L and removed size/XL labels

abh3po added 2 commits

November 22, 2016 20:20


          AnnotationBear: Return precise string/comment info

ca1744f

Earlier the return used to be either a tuple of source ranges
of strings/comments now it is a tuple of namedtuples with fields
"start_delimiter_range end_delimiter_range content_range full_range"
of singleline strings/multiline strings/singlieline comments/
multiline comments


          IndentationBear: Adapt to AnnotationBear changes

48cbc8e

abh3po force-pushed the fixannot branch from 46f6489 to 48cbc8e Compare

November 22, 2016 14:51

gitmate-bot added size/XL and removed size/L labels

sils added the status/blocked label

Member

sils commented Nov 22, 2016

DO NOT MERGE this, it will break QuotesBear e.g.

sils added process/wip and removed process/pending review labels

Collaborator

gitmate-bot commented Nov 29, 2016

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

7 similar comments

Collaborator

gitmate-bot commented Dec 6, 2016

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented Dec 13, 2016

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented Dec 21, 2016

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented Dec 28, 2016

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented Dec 28, 2016

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented Jan 5, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented Jan 12, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Member

sils commented Jan 12, 2017

@abhsag24 can we get this going again? We have feature freeze on 21st and this is really really needed

Collaborator

gitmate-bot commented Jan 19, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented Feb 3, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

6 similar comments

Collaborator

gitmate-bot commented Feb 11, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented Feb 18, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented Feb 18, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented Feb 25, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented Mar 5, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented Mar 12, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Member

aptrishu commented Mar 19, 2017

You can close this PR. :P

Collaborator

gitmate-bot commented Mar 27, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

19 similar comments

Collaborator

gitmate-bot commented Apr 3, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented Apr 10, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented Apr 10, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented Apr 17, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented Apr 24, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented May 1, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented May 8, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented May 15, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented May 15, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented May 22, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented May 29, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented Jun 6, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented Jun 13, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented Jun 20, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented Jun 20, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented Jun 27, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented Jul 4, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented Jul 11, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented Jul 18, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot added the status/STALE label

jayvdb removed the status/blocked label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

process/wip size/XL status/STALE