WIP: Add ImageCompressionBear #1302
Conversation
|
Thanks for your contribution! Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.
As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well! |
yukiisbored
force-pushed
the
image-compressor-bear
branch
2 times, most recently
from
de7f821 to
e8d5aea
Compare
yukiisbored
force-pushed
the
image-compressor-bear
branch
from
e8d5aea to
7f6bd36
Compare
bears/image/ImageCompressionBear.py
Outdated
| CAN_DETECT = {'Compression', 'Useless metadata'} | ||
|
|
||
| @classmethod | ||
| def check_prerequisites(cls): |
There was a problem hiding this comment.
The reason for this is the fact DistributionRequirement doesn't implement is_installed. Related issue: https://gitlab.com/coala/package_manager/issues/11
yukiisbored
force-pushed
the
image-compressor-bear
branch
from
7f6bd36 to
e444f40
Compare
yukiisbored
force-pushed
the
image-compressor-bear
branch
from
e444f40 to
110aa01
Compare
gitmate-bot
added
process/pending review
size/XXL
and removed
process/wip
size/XL
labels
|
This PR requires https://gitlab.com/coala/package_manager/merge_requests/13 and |
|
in that case i am marking WIP, @yukiisbored 😅 |
bears/image/ImageCompressionBear.py
Outdated
| from coala_utils.FileUtils import create_tempfile | ||
|
|
||
|
|
||
| class ImageCompressionBear(LocalBear): |
There was a problem hiding this comment.
uhm... you should add, a short description of this bear, and a link to where more information can be fetch
bears/image/ImageCompressionBear.py
Outdated
| AUTHORS = {'The coala developers'} | ||
| AUTHORS_EMAILS = {'The coala developers'} | ||
| LICENSE = 'AGPL-3.0' | ||
| CAN_DETECT = {'Compression', 'Useless metadata'} |
There was a problem hiding this comment.
push a commit to the coala rep that adds these
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
3 similar comments
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
This PR is on hold, due to unresolved issues on gitlab.com/coala/package_manager related to handling DistributionRequirement and ExecutableRequirement fallback. |
|
@yukiisbored Add |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
1 similar comment
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
5 similar comments
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
3 similar comments
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
coala/coala#3560 is merged. This bear can now proceed. |
yukiisbored
force-pushed
the
image-compressor-bear
branch
3 times, most recently
from
d586635 to
cdb357b
Compare
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
2 similar comments
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
This bear cannot proceed efficiently without fixing the issues related to DistributionRequirement and AnyOneOfRequirement |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
1 similar comment
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
ImageCompressionBear is a bear which uses optimage, jpegoptim, jpegtran, pngcrush, optipng to see if the image can be compressed and how much bytes will be reduced if it's compressed. Closes coala#1259
yukiisbored
force-pushed
the
image-compressor-bear
branch
from
cdb357b to
a0c8d47
Compare
| @@ -53,6 +53,10 @@ addons: | |||
| - opam | |||
| - php-codesniffer | |||
| - verilator | |||
| - jpegoptim | |||
There was a problem hiding this comment.
the templates will now automatically generate this for the precise job.
Ideally, you also add it to either the hand coded xenial or trusty job that run in the first batch of jobs, in .moban.dt/travis-manual-matrix.yaml
| ExecutableRequirement('optipng') | ||
| ]), | ||
| AnyOneOfRequirements([ | ||
| DistributionRequirement(apt_get='zopfli', |
There was a problem hiding this comment.
Zopflipng wouldn't get installed on Ubuntu 16.04 which travis runs. by apt-get zopfli.
To install zopflipng:
git clone https://github.com/google/zopfli.git
cd zopfli
make zopflipng
install -Dm755 zopflipng /usr/local/bin/zopflipng
ImageCompressionBear is a bear which uses optimage, jpegoptim, jpegtran,
pngcrush, optipng to see if the image can be compressed and how much
bytes will be reduced if it's compressed.
Closes #1259