Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.coafile: Check all Python files #2584

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jayvdb
Copy link
Member

@jayvdb jayvdb commented Jul 6, 2018

Builds on top of #2541

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@jayvdb
Copy link
Member Author

jayvdb commented Jul 6, 2018

Something is wrong with Travis CI atm. apt-get is failing.

@jayvdb
Copy link
Member Author

jayvdb commented Jul 6, 2018

https://travis-ci.org/jayvdb/coala-bears/builds/400719488 is a possible workaround for the Circle CI failure.

@nemani
Copy link
Member

nemani commented Jul 7, 2018

@jayvdb Try to retry the ci job?

@jayvdb jayvdb force-pushed the coafile-all-python branch from 7bb716f to df3e899 Compare July 16, 2018 12:25
jayvdb added 2 commits July 16, 2018 19:33
Brings this file into line with the .coafile rules.

Related to coala#2582
Instead of checking specific directories, which omits
several existing Python files, and any new file not
in those directories, include all Python files and
explicitly exclude only generated docs/conf.py, and
ignore quotes in .ci/adjust_version_number.py

Also improves the use of `all` section in .coafile,
by introducing `all.python` for Python files.

Closes coala#2582
Related to coala#2397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants