-
Notifications
You must be signed in to change notification settings - Fork 0
HypervisorMaintenance: Trigger eviction based on maintenance flag #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a6999a0 to
9a7fee7
Compare
9a7fee7 to
e6dc936
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to have a call about this implementation.
The controller want's to take care of:
- Eviction condition
- the evicted status field probably makes also most sense in the eviction controller itself
- ready status
and conflicts with the other controllers, but it doesn't cleanup / remove stuff from other controllers. This feels too complex to be reviewed by me currently
When maintenance is set, it will trigger an eviction via the respective CRD and reflect the result back to the hypervisor status.
e6dc936 to
64f9483
Compare
|
I've used semantic equality, as controller-runtime also switched to that. I vaguely had in the back of my mind that there was some problem with |
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
When maintenance is set, it will trigger an eviction via the respective CRD and reflect the result back to the hypervisor status.