mmaprototype: add more error cases in TestNormalizedVoterAllRelationships #158656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds assertions on emptyVoterConstraintIndex and emptyConstraintIndex since there should only be one.
This commit refactors some code in doStructuralNormalization to use min utility and also adds assertions on programming errors.
This commit fixes >= 0 when checking for whether there were valid emptyVoterConstraintIndex and emptyConstraintIndex since 0 is a valid index.
wenyihu6
changed the title
Member
|
This change is |
wenyihu6
changed the title
A=[+region=a, +zone=a1], B=[+region=a, +zone=a2] is now classified as non-intersecting. This fixes an existing todo. Epic: CRDB-55052 Release note: None # Conflicts: # pkg/kv/kvserver/allocator/mmaprototype/constraint.go
Previously, we started returning conjNonIntersecting when we encounter same type, same key, different values. However, the fix only returned early if the differing value is encountered from cc. This commit changed it so that we also check and return early for b.
Contributor
Author
|
@sumeerbhola I ended up cherry-picking your commit and added more tests as part of the work. So I will close #158380 in favor of this one if it looks good to you. |
Potential Bug(s) DetectedThe three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation. Next Steps: Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary. After you review the findings, please tag the issue as follows:
|
github-actions
bot
added
the
o-AI-Review-Potential-Issue-Detected
Contributor
Author
|
Closing in favor of #158722. Opened a new PR since this one hasn’t been reviewed yet, which should make reviewable cleaner given my rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #158393. Only the last 5 commits.
Epic: CRDB-55052
Release note: none
mmaprototype: add more error cases test coverage
mmaprototype: improve comment on relationship
mma: additional case for non-intersecting conjunctions
A=[+region=a, +zone=a1], B=[+region=a, +zone=a2] is now classified as
non-intersecting. This fixes an existing todo.
mmaprototype: fix conjNonIntersecting
Previously, we started returning conjNonIntersecting when we encounter
same type, same key, different values. However, the fix only returned
early if the differing value is encountered from cc. This commit changed
it so that we also check and return early for b.
mmaprototype: add test cases for conjNonIntersecting