sql: extend SST writer support to legacy schema changer backfill #158684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
spilchen
force-pushed
the
gh-158378/251203/0816/merge/sst-write-legacy-backfill
branch
from
31a93f2 to
bde731b
Compare
Previously, SST writer support during index backfill with distributed merge was only available in the declarative schema changer (added in cockroachdb#158456). This commit extends the same logic to the legacy schema changer. To avoid duplication, shared logic was extracted into a helper function reused by both. Informs cockroachdb#158378 Epic: CRDB-48845 Release note: none
spilchen
force-pushed
the
gh-158378/251203/0816/merge/sst-write-legacy-backfill
branch
from
bde731b to
66ce999
Compare
spilchen
requested review from
dt,
fqazi,
mw5h and
yuzefovich
and removed request for
a team
Contributor
Author
|
TFTR! bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, SST writer support during index backfill with distributed merge was only available in the declarative schema changer (added in #158456). This commit extends the same logic to the legacy schema changer. To avoid duplication, shared logic was extracted into a helper function reused by both.
Informs #158378
Epic: CRDB-48845
Release note: none