-
Notifications
You must be signed in to change notification settings - Fork 4k
opt: route descriptor lookups for AFTER triggers through cache #158708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fqazi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fqazi reviewed 2 of 2 files at r1, 2 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball)
DrewKimball
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It might also be worth adding a comment to
FullyQualifiedName to warn people away from using it over methods that go through the cache.
@DrewKimball reviewed 2 of 2 files at r1, 2 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status:complete! 2 of 0 LGTMs obtained (waiting on @mgartner)
The interface already mentions this: cockroach/pkg/sql/opt/cat/catalog.go Lines 263 to 264 in 59e8ced
I copied these notes to the opt catalog implementation too. |
These tests have a non-conventional construction that make it hard to
determine how they can be run. Each subset of tests is not a typical Go
function like `func TestAThing(t *testing.T) { ... }` that can be easily
searched for. A few comments have been added to explain how the tests
can be run.
Release note: None
Release note: None
This commit applies the fix in cockroachdb#144217 for `BEFORE` triggers to `AFTER` triggers. See that PR for more details. Fixes cockroachdb#144211 Release note (performance improvement): After triggers now perform the descriptor lookup for `TG_TABLE_SCHEMA` against a cache. This can significantly reduce trigger planning latency.
Release note: None
0119d11 to
e01b2d3
Compare
|
TFTRs! bors r+ |
|
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #144211: branch-release-25.3, branch-release-25.4. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. 💡 Consider backporting to the fork repo instead of the main repo. See instructions for more details. error creating merge commit from 5f69f7b to blathers/backport-release-25.2-158708: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 25.2.x failed. See errors above. 💡 Consider backporting to the fork repo instead of the main repo. See instructions for more details. error creating merge commit from 364a865 to blathers/backport-release-25.3-158708: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 25.3.x failed. See errors above. 💡 Consider backporting to the fork repo instead of the main repo. See instructions for more details. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
bench/rttananlysis: document directions for running tests
These tests have a non-conventional construction that make it hard to
determine how they can be run. Each subset of tests is not a typical Go
function like
func TestAThing(t *testing.T) { ... }that can be easilysearched for. A few comments have been added to explain how the tests
can be run.
Release note: None
bench/rttanalysis: add test case with an after trigger
Release note: None
opt: route descriptor lookups for AFTER triggers through cache
This commit applies the fix in #144217 for
BEFOREtriggers toAFTERtriggers. See that PR for more details.
Fixes #144211
Release note (performance improvement): After triggers now perform the
descriptor lookup for
TG_TABLE_SCHEMAagainst a cache. This cansignificantly reduce trigger planning latency.
opt: warn about performance of (*optCatalog).FullyQualifiedName
Release note: None