Skip to content

Conversation

@rickystewart
Copy link
Collaborator

@rickystewart rickystewart commented Dec 3, 2025

Backport 1/1 commits from #158548 on behalf of @rickystewart.


We will use this in a new helper tool later.

Part of: DEVINF-1649
Release note: none
Epic: DEVINF-1582


Release justification: Non-production code changes

We will use this in a new helper tool later.

Part of: DEVINF-1649
Release note: none
Epic: DEVINF-1582
@rickystewart rickystewart force-pushed the blathers/backport-release-25.2-158548 branch from 55934a3 to 197fd3e Compare December 3, 2025 21:58
@rickystewart rickystewart requested review from a team as code owners December 3, 2025 21:58
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 3, 2025
@rickystewart rickystewart requested review from herkolategan and williamchoe3 and removed request for a team December 3, 2025 21:58
@blathers-crl
Copy link

blathers-crl bot commented Dec 3, 2025

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-code-systems labels Dec 3, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl
Copy link

blathers-crl bot commented Dec 3, 2025

❌ PR #158710 does not comply with backport policy

Confidence: high
Explanation: The pull request introduces modifications to production code, specifically within helper tools and internal functions, as evidenced by the changes in 'pkg/cmd/bazci/githubpost/githubpost.go' and 'pkg/internal/codeowners/codeowners.go'. These modifications do not fulfill the critical bug criteria specified in the policy. The changes primarily include the extraction and refactoring of methods related to testing ownership determination, and the integration of a new helper function into existing tools. There is no evidence of the changes addressing stability or security issues, data loss, significant performance regressions, or corrections of incorrect database results. The code changes do not implement any feature flags or cluster settings that would enable gating of these changes, nor meet the criteria to be considered as such.
Recommendation: Reconsider the backport or introduce a feature flag to gate these changes

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@rickystewart rickystewart merged commit 5dade7c into cockroachdb:release-25.2 Dec 4, 2025
15 of 16 checks passed
@rickystewart rickystewart deleted the blathers/backport-release-25.2-158548 branch December 4, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-code-systems target-release-25.2.11

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants