Skip to content

Conversation

@rickystewart
Copy link
Collaborator

Backport 1/1 commits from #158548.

/cc @cockroachdb/release


We will use this in a new helper tool later.

Part of: DEVINF-1649
Release note: none
Epic: DEVINF-1582

We will use this in a new helper tool later.

Release justification: Non-production code changes

Part of: DEVINF-1649
Release note: none
Epic: DEVINF-1582
@rickystewart rickystewart requested a review from rail December 3, 2025 22:14
@rickystewart rickystewart requested review from a team as code owners December 3, 2025 22:15
@rickystewart rickystewart requested review from golgeek and herkolategan and removed request for a team December 3, 2025 22:15
@blathers-crl
Copy link

blathers-crl bot commented Dec 3, 2025

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-code-systems labels Dec 3, 2025
@blathers-crl
Copy link

blathers-crl bot commented Dec 3, 2025

❌ PR #158714 does not comply with backport policy

Confidence: high
Explanation: The pull request involves changes to files that do not solely fall within non-production patterns specified by the policy. Specifically, the changes in pkg/internal/codeowners/codeowners.go and pkg/cmd/bazci/githubpost/githubpost.go suggest modifications to potentially production or core utility functionalities, which are not solely related to testing, development environment, or build configuration. There is no evidence of a 'Release justification' line in the PR body, indicating these changes need to be critically justified or gated behind a feature flag. The body of the PR does not claim that these changes fix a critical bug, nor do they appear to be related to addressing stability, security issues, or data corruption/loss, or address any performance or incorrect database results. Moreover, no new cluster or session settings are introduced which can act as feature flags, nor is there any apparent gating mechanism for these changes being presented.
Recommendation: Request to reconsider the backport or provide a 'Release justification' explaining why these changes should be backported without being gated behind a feature flag.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rickystewart rickystewart merged commit 641359e into cockroachdb:release-24.3 Dec 4, 2025
14 of 16 checks passed
@rickystewart rickystewart deleted the backport24.3-158548 branch December 4, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches T-code-systems target-release-24.3.25

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants