Skip to content

Conversation

@florence-crl
Copy link
Contributor

@florence-crl florence-crl commented Sep 25, 2025

Fixes DOC-14578 DOC-14617 DOC-14625 DOC-14653

  • In logging-overview.md, (a) added log.channel_compatibility_mode.enabled section, (b) updated Logging channels table with notes with link to log.channel_compatibility_mode.enabled, and (c) updated Log destinations table.
  • In configure-logs.md, logging-use-cases.md, and log-sql-activity-to-datadog, added note with link to log.channel_compatibility_mode.enabled.
  • In configure-logs.md, added kv-exec to Default logging configuration.

Rendered previews

…led section, (b) updated Logging channels table with notes with link to log.channel_compatibility_mode.enabled, and (c) updated Log destinations table.

In configure-logs.md, logging-use-cases.md, and log-sql-activity-to-datadog, added note with link to log.channel_compatibility_mode.enabled.

In configure-logs.md, added kv-exec to Default logging configuration.
@netlify
Copy link

netlify bot commented Sep 25, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit d36c037
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/690125b443916a0008ab9cfd

@netlify
Copy link

netlify bot commented Sep 25, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit d36c037
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/690125b4c130fa0008c27dc3

@netlify
Copy link

netlify bot commented Sep 25, 2025

Netlify Preview

Name Link
🔨 Latest commit d36c037
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/690125b43716220008805715
😎 Deploy Preview https://deploy-preview-20434--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

@kevin-v-ngo kevin-v-ngo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Few nits.

| [`DEV`]({% link {{ page.version.version }}/logging.md %}#dev) | Uncategorized and debug messages. |
| [`OPS`]({% link {{ page.version.version }}/logging.md %}#ops) | Process starts, stops, shutdowns, and crashes (if they can be logged); changes to cluster topology, such as node additions, removals, and decommissions. |
| [`KV_DISTRIBUTION`]({% link {{ page.version.version }}/logging.md %}#kv_distribution) | Data distribution events, such as moving [replicas]({% link {{ page.version.version }}/architecture/overview.md %}#architecture-replica) between [stores]({% link {{ page.version.version }}/cockroach-start.md %}#store) in a cluster, adding replicas to [ranges]({% link {{ page.version.version }}/architecture/overview.md %}#range), and removing replicas from ranges. |
| <a id="kv_exec"></a><span class="version-tag">New in v25.4:</span> [`KV_EXEC`]({% link {{ page.version.version }}/logging.md %}) | KV execution events that are not related to distribution.|

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we provide any details on these events outside of this table?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I have no information about KV_EXEC events. KV_EXEC events are not even described in the master branch version of the eventlog.md

Copy link
Contributor Author

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR

| [`DEV`]({% link {{ page.version.version }}/logging.md %}#dev) | Uncategorized and debug messages. |
| [`OPS`]({% link {{ page.version.version }}/logging.md %}#ops) | Process starts, stops, shutdowns, and crashes (if they can be logged); changes to cluster topology, such as node additions, removals, and decommissions. |
| [`KV_DISTRIBUTION`]({% link {{ page.version.version }}/logging.md %}#kv_distribution) | Data distribution events, such as moving [replicas]({% link {{ page.version.version }}/architecture/overview.md %}#architecture-replica) between [stores]({% link {{ page.version.version }}/cockroach-start.md %}#store) in a cluster, adding replicas to [ranges]({% link {{ page.version.version }}/architecture/overview.md %}#range), and removing replicas from ranges. |
| <a id="kv_exec"></a><span class="version-tag">New in v25.4:</span> [`KV_EXEC`]({% link {{ page.version.version }}/logging.md %}) | KV execution events that are not related to distribution.|
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I have no information about KV_EXEC events. KV_EXEC events are not even described in the master branch version of the eventlog.md

Copy link
Contributor

@mikeCRL mikeCRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions included.

Also:

Wherever you mention "in a future release", consider updating to "in a future major release". While most readers would assume it, I think it is safer to be explicit.

Copy link
Contributor Author

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR

@florence-crl florence-crl requested a review from mikeCRL October 28, 2025 20:12
Copy link
Contributor

@mikeCRL mikeCRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

If you want to fix it, in src/current/v25.4/logging-overview.md, there are two spaces after the words this channel

@florence-crl
Copy link
Contributor Author

florence-crl commented Oct 28, 2025

If you want to fix it, in src/current/v25.4/logging-overview.md, there are two spaces after the words "this channel"

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants