Add IBM sections to release downloads and info for 25.3.2+ prod releases #20480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
Files changed:
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
|
@mikeCRL need your help with the |
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
jhlodin
force-pushed
the
jl/doc-12063-followup
branch
from
fcecdae to
79580b2
Compare
jhlodin
commented
Oct 6, 2025
jhlodin
force-pushed
the
jl/doc-12063-followup
branch
from
79580b2 to
550c797
Compare
|
Rendering on the page for a specific release. This section does not appear prior to 25.3 or on pre-production releases (like 25.4, currently): Rendering on the general releases page for an available production release: Rendering on the general releases page for an older release: Rendering on the general releases page for an upcoming, testing-only release: |
rmloveland
reviewed
Oct 8, 2025
| @@ -0,0 +1,113 @@ | |||
| {% comment %}This include is used only in v23.3.2 and above. Newer versions use release-downloads-docker-image.md. {% endcomment %} | |||
There was a problem hiding this comment.
@jhlodin would you say this is mostly a copy of new-release-downloads-docker-image.md modified with some new IBM-specific logic?
There was a problem hiding this comment.
Yes correct. It might be wise to rename that old file because new-* is now a misnomer.
There was a problem hiding this comment.
+1 great idea
"new" is ... always a less than great idea :-)
jhlodin
force-pushed
the
jl/doc-12063-followup
branch
from
eab04b1 to
67d522d
Compare
|
@mikeCRL @kenliu-crl @egunhouse FYI Joe is on PTO for a couple weeks so I'll be covering this PR for him, happy to update as needed based on your feedback and will merge when given the go-ahead by y'all |
mikeCRL
approved these changes
Oct 14, 2025
|
Thanks, @rmloveland (and Joe!). Formally approved, after having already discussed with Joe. |
|
@rmloveland please don't merge this yet, i have some feedback on this that I'll follow up with you on today or tomorrow. |
sure thing @kenliu-crl , happy to make any updates. def not merging until we get your explicit 👍 |
jhlodin
force-pushed
the
jl/doc-12063-followup
branch
from
67d522d to
46f30bc
Compare
kenliu-crl
approved these changes
Oct 29, 2025
Add IBM section and links to applicable releases
jhlodin
force-pushed
the
jl/doc-12063-followup
branch
from
f35fd78 to
d28ae3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to https://cockroachlabs.atlassian.net/browse/DOC-12063
new-release-downloads-and-docker-image.mdinclude that adds IBM release info (conditionally; doesn't include in non-production releases)releases/page with logic displaying different content based on the version number and release status: