Skip to content

Conversation

jhlodin
Copy link
Contributor

@jhlodin jhlodin commented Oct 2, 2025

Follow-up to https://cockroachlabs.atlassian.net/browse/DOC-12063

  • Create new version of the new-release-downloads-and-docker-image.md include that adds IBM release info (conditionally; doesn't include in non-production releases)
  • Add IBM tab to list of OS tabs on the releases/ page with logic displaying different content based on the version number and release status:
    • Releases prior to v25.3 state that IBM is not available until 25.3+
    • Testing releases state that IBM is only available on production releases.

Copy link

netlify bot commented Oct 2, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 14863fa
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/68e55bdfa24616000868da01

Copy link

github-actions bot commented Oct 2, 2025

Files changed:

Copy link

netlify bot commented Oct 2, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 14863fa
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/68e55bdf1b5d580008df5aa8

@jhlodin
Copy link
Contributor Author

jhlodin commented Oct 2, 2025

@mikeCRL need your help with the releases/index.md page logic. The page does not seem to like rendering a tab-selector with options that are not available in the other tab-selectors on the page.

@jhlodin jhlodin requested a review from mikeCRL October 2, 2025 20:45
Copy link

netlify bot commented Oct 2, 2025

Netlify Preview

Name Link
🔨 Latest commit 14863fa
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/68e55bdf88eca7000809b33d
😎 Deploy Preview https://deploy-preview-20480--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jhlodin jhlodin force-pushed the jl/doc-12063-followup branch from fcecdae to 79580b2 Compare October 6, 2025 19:42
Comment on lines 252 to 271
{% comment %} Add IBM tab to non-testing releases since v25.3 {% endcomment %}
{% if v.major_version == 'v23.1' or
v.major_version == 'v23.2' or
v.major_version == 'v23.3' or
v.major_version == 'v23.4' or
v.major_version == 'v24.1' or
v.major_version == 'v24.2' or
v.major_version == 'v24.3' or
v.major_version == 'v24.4' or
v.major_version == 'v25.1' or
v.major_version == 'v25.2' or
released == false %}
<div id="os-tabs" class="filters filters-big clearfix">
<button id="linux" class="filter-button" data-scope="linux">Linux</button>
<button id="mac" class="filter-button" data-scope="mac">Mac</button>
<button id="windows" class="filter-button" data-scope="windows">Windows</button>
<button id="docker" class="filter-button" data-scope="docker">Docker</button>
<button id="source" class="filter-button" data-scope="source">Source</button>
</div>
{% else %}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workshopped with Mike - should include the IBM tab in all releases, then set the conditional to modify the content.

Add IBM section and links to applicable releases
@jhlodin jhlodin force-pushed the jl/doc-12063-followup branch from 79580b2 to 550c797 Compare October 7, 2025 18:06
@jhlodin jhlodin marked this pull request as ready for review October 7, 2025 18:28
@jhlodin
Copy link
Contributor Author

jhlodin commented Oct 7, 2025

Rendering on the page for a specific release. This section does not appear prior to 25.3 or on pre-production releases (like 25.4, currently):
Screenshot 2025-10-07 at 2 32 38 PM

Rendering on the general releases page for an available production release:
Screenshot 2025-10-07 at 2 33 53 PM

Rendering on the general releases page for an older release:
Screenshot 2025-10-07 at 2 34 24 PM

Rendering on the general releases page for an upcoming, testing-only release:
Screenshot 2025-10-07 at 2 34 54 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant