Skip to content

Conversation

@peachdawnleach
Copy link
Contributor

Addresses: DOC-15034 and DOC-14967

Added new page on the upgrade process with pcr enabled, including more detailed and accurate info than we had previously.

Added new page on the upgrade process with pcr enabled, including more detailed and accurate info than we had previously
@netlify
Copy link

netlify bot commented Oct 21, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 9b38a8c
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/69010d75b703d50008568e57

@netlify
Copy link

netlify bot commented Oct 21, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 9b38a8c
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/69010d758c687000081a3129

@netlify
Copy link

netlify bot commented Oct 21, 2025

Netlify Preview

Name Link
🔨 Latest commit 9b38a8c
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/69010d7516b9400008c65b37
😎 Deploy Preview https://deploy-preview-20729--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Fixed summary to be the right length
@peachdawnleach
Copy link
Contributor Author

@peachdawnleach
Copy link
Contributor Author

Changes to 25.4 aren't in this PR yet, but will be added as identical to 25.3 once the changes are finalized- easier to make adjustments in just the one version

A few small adjustments based on tech review
Removed cloud only components and adjusting steps to match source of truth doc
Copy link

@msbutler msbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I'll let @alicia-l2 give this a review

Copy link

@alicia-l2 alicia-l2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really good draft, left some remaining comments! thanks!

1. [Finalize]({% link {{ page.version.version }}/upgrade-cockroach-version.md %}#finalize-a-major-version-upgrade-manually) the upgrade on the primary cluster's SystemVC.

{{site.data.alerts.callout_info}}
If you need to [roll back]({% link {{ page.version.version }}/upgrade-cockroach-version.md %}#roll-back-a-major-version-upgrade) an upgrade, you must do so before the upgrade has been finalized. Rolling back the upgrade on the primary cluster does not also roll back the standby cluster.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for readability should we say "primary cluster does not roll backup" instead of "does not also"

Some rewordings
Copy link

@alicia-l2 alicia-l2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for addressing all these changes! left one small nit

Ported to 24.3, 25.2, 25.4
Removed broken links
Copy link
Contributor

@jhlodin jhlodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments and suggestions.

It's not clear to me whether SystemVC/AppVC/ReaderVC is the correct terminology versus system virtual cluster/app virtual cluster/reader virtual cluster because both are used throughout the docs.

My 2c is that virtual clusters are a generic CRDB technical term not specific to PCR, so unless the product itself uses the "SystemVC" shortening I think we are best off with the longer name. Or at least not capitalizing System/App/Reader so it doesn't look like a Brand ™️

@alicia-l2
Copy link

alicia-l2 commented Oct 27, 2025

Left comments and suggestions.

It's not clear to me whether SystemVC/AppVC/ReaderVC is the correct terminology versus system virtual cluster/app virtual cluster/reader virtual cluster because both are used throughout the docs.

My 2c is that virtual clusters are a generic CRDB technical term not specific to PCR, so unless the product itself uses the "SystemVC" shortening I think we are best off with the longer name. Or at least not capitalizing System/App/Reader so it doesn't look like a Brand ™️

good point @jhlodin . I think we should keep the VC shortening, see doc here: https://docs.google.com/document/d/1nZApVf2NX3-BV_D6FJTsAGWpiNBhJVhDwsepKzttoVA/edit?tab=t.0#heading=h.1iolcwo8w939

but , we should probably not capitalize Reader or App and should have a space in between Reader and VC, so it's like reader VC.

peachdawnleach and others added 6 commits October 27, 2025 16:32
updated pages to have standardized 'system VC' 'app VC' 'reader VC' language
Changes from docs review- still need to add code snippets
Added code snippets to entire upgrade process
Two instances of readervc didn't get changed
Copy link

@msbutler msbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New code examples look good to me!

Copy link
Contributor

@jhlodin jhlodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more small suggestions, otherwise LGTM

Added some links
whoops broken link
@peachdawnleach peachdawnleach enabled auto-merge (squash) October 28, 2025 18:38
@peachdawnleach peachdawnleach merged commit eafa471 into main Oct 28, 2025
6 checks passed
@peachdawnleach peachdawnleach deleted the 20251014-DOC-14967-reader-vc-upgrade branch October 28, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants