Add agent memory retrieval safety skill - #20
Open
milos-plavsic wants to merge 1 commit into
Open
milos-plavsic wants to merge 1 commit into
milos-plavsic wants to merge 1 commit into
Conversation
4 tasks
milos-plavsic
marked this pull request as ready for review
September 5, 2026 16:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a focused Agent Skill for reviewing CockroachDB-backed semantic-memory retrieval before an application treats ranked memories as trustworthy.
The workflow separates four commonly conflated control planes:
It also covers embedding-space compatibility, bounded retrieval, non-executing plan inspection, synthetic boundary tests, explicit abstention, and a redacted report template.
This is a draft pending maintainer alignment on the proposal and scope.
Related Issue
Closes #19
Type of Change
Skill Compliance Checklist
name,description)references/for detailed content)scripts/,references/,assets/subdirs)python scripts/validate-spec.py skills/Documentation Updates
references/report-template.mdTesting
Manual testing:
EXPLAIN; the skill intentionally provides no mutation scriptAutomated testing:
quick_validate.pypassespython scripts/validate-spec.py skills/cockroachdb-application-development/verifying-agent-memory-retrieval-safety/The repository validator emits a non-blocking suggestion because its gerund allow-list does not recognize
verifying, although the name is already a gerund and follows the proposal in #19.Reviewer Notes
Please focus on whether the boundary between application retrieval policy and database authorization is crisp enough, and whether the read-only
EXPLAINguidance is appropriately conservative.By submitting this PR, I confirm: