Try to implement notion backend #725
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgeh0
reviewed
Jul 11, 2025
| let content = self.fetch_page_content(page_id.as_ref()).await?; | ||
|
|
||
| let fields = vec
There was a problem hiding this comment.
page ID is the key column, not a value column. Thisget_value() function takes key as input and return value columns. So page ID shouldn't be here.
The error is because fields put here doesn't match output schema returned by get_output_schema() below (for a KTable, first is key column, the remaining are value columns, so the value here is expected to match the remaining columns).
We will need to have validation to check schema of values returned here matching the declared schema (created #735 for this), so such problem can be easily caught and understandable in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation has error:
[2025-07-09T05:32:58Z ERROR cocoindex_engine::execution::source_indexer] JoinError::Panic(Id(33), "Field is already set, violating single-definition rule: KTable({Range(RangeValue { start: 0, end: 5 }): ScopeValueBuilder { fields: [OnceLock(Basic(Str("test1"))), OnceLock(Struct(FieldValues { fields: [Basic(Int64(0)), Basic(Int64(1)), Basic(Int64(1))] })), OnceLock(Struct(FieldValues { fields: [Basic(Int64(5)), Basic(Int64(1)), Basic(Int64(6))] })), OnceLock()] }})", ...)
Please double check.