Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix MaterialID type err #20537

Open
wants to merge 1 commit into
base: v4
Choose a base branch
from
Open

fix MaterialID type err #20537

wants to merge 1 commit into from

Conversation

StarBeat
Copy link

MaterialID是由hash计算得来的unsigned int型，drawBatchedTriangles函数prevMaterialID为int型，可能导致batch失败

u0u0 added a commit to u0u0/Cocos2d-Lua-Community that referenced this pull request Jun 21, 2020
@u0u0
fix MaterialID type err. cocos2d/cocos2d-x#20537
5e2e425
zhongfq added a commit to zhongfq/cocos-lua that referenced this pull request Jun 28, 2020
@zhongfq
fix material id type err
42dd179 
cocos2d/cocos2d-x#20537
@kibernet
Copy link

kibernet commented Jun 29, 2020 •
edited
Loading

这个 isValidMaterialID 的赋值有问题，每次循环时 isValidMaterialID 都是true，
if (!batchable)
isValidMaterialID = false;

下面紧接着 isValidMaterialID = true;这是有问题的。

@halx99 halx99 mentioned this pull request Jul 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StarBeat @kibernet