Updated readme to specify to build #20577
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readme didn't tell me how to build; I could see it was a cmake project, so I understood, but it should really be all there atop the readme. I also changed the title so it's clear these are build instructions (rather than 'note for git users'), and moved a requirement for linux building up into those steps, instead of being way down by the runtime instructions. That last one may not be entirely correct, since I'm not sure if that step is needed for building cocos2d itself, the application you make using cocos, or both. If it is only for the application you intend to make, then it should be moved back down.