V4 spriteframe erase fix #20580
Open
V4 spriteframe erase fix #20580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with master branch
Sync with master
Sync with master
Sync with master
Sync with master
Sync with master
…plist entry if and only if all frames belonging to that plist have been removed.
halx99
added a commit
to axmolengine/axmol
that referenced
this pull request
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue described in #20579
When all frames belonging to a specific plist are removed from the cache, then the plist cache entry is also removed.
Previously, all plists are removed even though their frames still exist in the cache, which is not correct.