Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 fix to stop iOS from converting an image into non-premultiplied alpha on save #20614

Open
wants to merge 7 commits into
base: v4
Choose a base branch
from
Open

v4 fix to stop iOS from converting an image into non-premultiplied alpha on save #20614

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c98560e
Merge pull request #12 from cocos2d/v4
rh101 Sep 23, 2019
3b19ecc
Merge pull request #14 from cocos2d/v4
rh101 Sep 27, 2019
310d717
Merge pull request #18 from cocos2d/v4
rh101 Dec 10, 2019
3085453
Merge pull request #20 from cocos2d/v4
rh101 Dec 29, 2019
8e46166
Merge pull request #21 from cocos2d/v4
rh101 May 14, 2020
d3dc5ad
Merge pull request #22 from cocos2d/v4
rh101 Sep 14, 2020
e3a0477
Fix to prevent iOS from converting PMA to non-PMA on save.
rh101 Nov 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions cocos/platform/ios/CCImage-ios.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,14 +87,7 @@ of this software and associated documentation files (the "Software"), to deal
CGBitmapInfo bitmapInfo = kCGBitmapByteOrderDefault;
if (saveToPNG && hasAlpha() && (! isToRGB))
{
if (_hasPremultipliedAlpha)
{
bitmapInfo |= kCGImageAlphaPremultipliedLast;
}
else
{
bitmapInfo |= kCGImageAlphaLast;
}
bitmapInfo |= kCGImageAlphaLast;
}
CGDataProviderRef provider = CGDataProviderCreateWithData(nullptr, pixels, myDataLength, nullptr);
CGColorSpaceRef colorSpaceRef = CGColorSpaceCreateDeviceRGB();
Expand Down