Skip to content

feat:adds David Smith Lesson09 "davidsmith.json" #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 23, 2024
Merged

feat:adds David Smith Lesson09 "davidsmith.json" #310

merged 3 commits into from
Oct 23, 2024

Conversation

dxsmith244
Copy link
Contributor

Adds DavidSmithProvider.java and davidsmith.json for lesson 09 homework

anthonydmays
anthonydmays requested changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@anthonydmays anthonydmays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you needed to run ./gradlew spotlessApply to fix formatting issues. The checks should pass after you push that change.

@dxsmith244
Copy link
Contributor Author

Ran the command and build is still failing.

@anthonydmays anthonydmays merged commit 5d4d407 into code-differently:main Oct 23, 2024
1 check passed
@dxsmith244 dxsmith244 deleted the DavidSmith_Lesson09 branch October 24, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonydmays anthonydmays anthonydmays requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dxsmith244 @anthonydmays @Dsmith07