Skip to content

chore: reinstate a file that was deleted in Lesson17 #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

NelltheWiz
Copy link
Contributor

I deleted a file by accident. I am also working on doing this lesson in its entirety.

Copy link
Contributor

@VicenteVigueras VicenteVigueras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's totally fine if you'd like to move on from this homework. I'm going to close this PR for now, but that doesn't mean you can't continue working on it.

I’ve left some comments if you decide to pick it up again. Lastly, remember to run spotless apply whenever you're working on Java before pushing your code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class looks good overall. In the class declaration, I'd change the class name from "BusinessChecking" to "BusinessCheckingAccount"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this file is empty. You might have forgotten to push the code, or perhaps you didn't intend to upload it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic here seems off, I'm not sure what your intention was.

It looks like you were trying to create a superclass called 'Account' to be extended by 'CheckingAccount' and 'SavingsAccount'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants