Skip to content

feat: Revised Lesson17 bankATM simulator with full test coverage #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Ananatawa
Copy link
Contributor

Finally completed my Lesson17 homework with all tests passing! Used ChatGPT a LOT to help me correct errors when tests were failing and to come up with a conventional commit message. Thanks!

@@ -0,0 +1,6 @@
package com.codedifferently.lesson17.bank;

public enum CustomerType {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job using an Enum here! I’ve never seen it done this way before, but it makes perfect sense since a Customer can only be either an Individual or a Business, nothing more

Copy link
Contributor

@VicenteVigueras VicenteVigueras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the code! It's a positive use of AI. It would be helpful for you to revisit why you used an abstract class, inheritance, and overriding, as these OOP principles are important.

I'll close this PR now, it's a solid submission, no need for another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants