Adding a temporary fix to stop non-maintainers from RCE #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a change to our CI/CD process concerning the AWS CodeBuild project. Specifically, we’re implementing a filter to the primary GitHub source, which checks against a regex pattern of user IDs. These IDs currently represent our existing maintainers and repository owners. While this is a quick, interim solution to a larger security issue, I acknowledge its unsustainability in the long run.
Security Issue Background
A vulnerability was identified where an external entity could push a change to the build spec in our public repositories. When this happens, GitHub sends a webhook push, and CodeBuild, in turn, reads and executes the modified build spec. This behavior effectively grants remote code execution capabilities in our environment. While we can limit access through specific IAM roles, the potential risk remains significant.
Long-Term Solution Ideas
The current change is a temporary measure. It’ll necessitate manual updates as team dynamics evolve. In the meantime, we’re actively exploring more sustainable solutions to ensure a secure CI/CD process.
See Child PR's: