CMS-840: Update home page ui tests #66625
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem-vavilov
force-pushed
the
CMS-840/home-page-ui-tests
branch
from
3c8288f to
eddc051
Compare
artem-vavilov
force-pushed
the
CMS-840/home-page-ui-tests
branch
from
eddc051 to
20b63f3
Compare
| @@ -15,6 +15,7 @@ Scenario: Create Dropdown does NOT show on level pages | |||
| @pegasus_content | |||
| Scenario: Signed Out - Correct Create Links | |||
| Given I am on "http://code.org" | |||
| And I dismiss the language selector | |||
There was a problem hiding this comment.
I recommend we use studio.code.org instead of home page instead (this test won't work there as none of these elements exist)
| @@ -63,7 +63,7 @@ Feature: Lab share page logo | |||
| And I navigate to the last shared URL | |||
| And element "div:contains('STUDIO')" does not exist | |||
| And I press the first "#logo-img img" element to load a new page | |||
| And check that I am on "http://code.org/" | |||
| And check that I am on "http://code.org/en-US" | |||
There was a problem hiding this comment.
Could we instead check the href of the logo image?
Comment on lines
125
to
129
| def jquery? | ||
| return false | ||
| @browser.execute_script("return (typeof jQuery !== 'undefined');") | ||
| end | ||
|
|
There was a problem hiding this comment.
The jquery detection can probably be removed (in general I think the dashboard ui tests shouldn't enter the new marketing sites)
| @@ -8,7 +8,7 @@ Feature: GDPR Dialog - data transfer agreement | |||
| And I am on "http://studio.code.org/home" | |||
| When element ".ui-test-gdpr-dialog" is visible | |||
| Then I click selector ".ui-test-gdpr-dialog-logout" | |||
| Then I wait until I am on "http://code.org/" | |||
| Then I wait until I am on "http://code.org/en-US" | |||
There was a problem hiding this comment.
Could this be a check for the href instead? I'd like to avoid actually going to the marketing sites if possible.
This reverts commit 20b63f3.
artem-vavilov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed tests:
Links