fix(redirect): return 200 when redirect not found #66935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally the redirect API returned 404 when a redirect entry was not found. However, this causes a lot of noise on New Relic where it detects the 404 as an 'error'. To mitigate this, the API now returns an OK response but when the `redirectEntry` as null if the entry is not found.
kelbyhawn
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally the redirect API returned 404 when a redirect entry was not found. However, this causes a lot of noise on New Relic where it detects the 404 as an 'error'. To mitigate this, the API now returns an OK response but when the
redirectEntryas null if the entry is not found.