Feature/oauth2 login#594
Merged
Merged
Conversation
|
@EDOHWARES is attempting to deploy a commit to the vic's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@EDOHWARES Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
@vic-Gray , pls review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement OAuth2 Social Login and Stellar Payment Channel Monitoring
This PR addresses and implements the acceptance criteria for two major backend features:
🚀 Key Implementations
1. OAuth2 Social Login (Google & GitHub)
GET /auth/google,GET /auth/githubalong with their callback handlers) using NestJS passport strategies (passport-google-oauth20andpassport-github2).user_oauth_links, avoiding signup friction while ensuring consistency by grouping OAuth links under identical email addresses.2. Stellar Payment Channel Monitoring
StellarClientServiceto establish a live streaming connection to Stellar Horizon usingserver.payments().forAccount(vaultFundingAccountId).stream().PaymentReceivedEventdomain event within seconds of ledger close./healthendpoint under thestellar_payment_streamkey.DepositConfirmedexecution pathway to trigger asynchronously only when the payment stream yields a matching ledger payment.3. Core Bugs & Test Suite Refactoring
isCurrentUserAdminwas evaluated as a promise in boolean contexts without being awaited (making checks evaluate totrueand allowing unauthorized actions).vaults.service.spec.tsandvaults.integration.spec.tsto accommodate the change from synchronous/atomic deposits and withdrawals to the new asynchronous CQRS/event-driven confirmation architecture.🛠️ Tech Stack & Dependencies Added
passport-google-oauth20,passport-github2,@nestjs/passport🧪 Verification & Test Results
All Vault-related test suites were run and passed successfully:
Closes #467
Closes #465
Closes #464
Closes #466