feat(vaults): add configurable entry, exit, and performance fees#623
Open
Kureszn wants to merge 3 commits into
Open
feat(vaults): add configurable entry, exit, and performance fees#623Kureszn wants to merge 3 commits into
Kureszn wants to merge 3 commits into
Conversation
- Add entryFeeBps, exitFeeBps, performanceFeeBps, feeAddress columns to vaults - Add FEE_COLLECTED event type to DepositEventType enum - Add FeesService with validation against platform-wide max caps (env-configurable) - Auto-collect entry fee on deposit, exit fee on withdrawal; log each as FEE_COLLECTED audit event - Net amounts credited to vault after fee deduction - Add PATCH /vaults/:vaultId/fees endpoint (owner-only) - Expose fee fields and feeAmount/netAmount in deposit/withdrawal responses - Add migration 1700000000019-AddVaultFees - Register FeesService in test modules to fix DI
|
@Kureszn is attempting to deploy a commit to the vic's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Kureszn Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Collaborator
|
@Kureszn pls resolve conflicts |
Author
|
Alright, I will get on with it right away. |
Author
|
Conflicts are fully resolved now |
Luluameh
pushed a commit
to Luluameh/Harvest-Finance
that referenced
this pull request
Jun 30, 2026
): add comprehensive test suite for vault events, escrow creation, indexer error handling, and full auth flow Tests added: - Vault WebSocket event emission tests for deposit, withdrawal, harvest, milestone, and AI insights events with room verification - Stellar escrow creation integration tests including fee-bump transactions and retry logic with exponential backoff - SorobanIndexerService error handling tests for RPC failures, malformed responses, network timeouts, and cache failures - Complete end-to-end authentication flow tests covering register, login, token refresh, and logout with session isolation and token validation Resolves code-flexing#621 Resolves code-flexing#622 Resolves code-flexing#623 Resolves code-flexing#624
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #507