Skip to content

moved SubclassJSONSerializer to krrood and added kwargs #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 3, 2025
Merged

moved SubclassJSONSerializer to krrood and added kwargs #25

merged 6 commits into from
Nov 3, 2025
+321 −0

Conversation

@ichumuh
Copy link
Contributor

@ichumuh ichumuh commented Oct 31, 2025 •
edited
Loading

  • krrood is a better place for this class than random events
  • adding kwargs allows us to pass data that the objects need for initialization, e.g., a connection needs a world to find the correct parent and child instances
  • implemented importlib version

@ichumuh ichumuh requested a review from tomsch420 October 31, 2025 11:37
tomsch420
tomsch420 requested changes Nov 1, 2025
View reviewed changes
AbdelrhmanBassiouny
AbdelrhmanBassiouny requested changes Nov 1, 2025
View reviewed changes
Copy link
Collaborator

@AbdelrhmanBassiouny AbdelrhmanBassiouny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea to move it here.

@AbdelrhmanBassiouny AbdelrhmanBassiouny merged commit 882bc00 into code-iai:main Nov 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AbdelrhmanBassiouny AbdelrhmanBassiouny AbdelrhmanBassiouny approved these changes

@tomsch420 tomsch420 tomsch420 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ichumuh @AbdelrhmanBassiouny @tomsch420