Skip to content

Annotator split #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Annotator split #333

wants to merge 4 commits into from

Conversation

SvenjaKern
Copy link
Contributor

@SvenjaKern SvenjaKern commented Aug 16, 2023 •
edited
Loading

PR checklist:

  • Tested by creator on localhost:8000/docs
  • Tested by creator on refinery
  • Tested by reviewer on localhost:8000/docs
  • Tested by reviewer on refinery
  • (If added) common code tested in notebook/ script
  • Conforms with the agreed upon code pattern

LeonardPuettmannKern
LeonardPuettmannKern requested changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@LeonardPuettmannKern LeonardPuettmannKern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are quite some things that need to be changed. Can you please have another look @SvenjaKern?

generators/numbers/annotator_split/config.py
"description": "only text fields",
"addInfo": [
BricksVariableType.ATTRIBUTE.value,
BricksVariableType.GENERIC_STRING.value,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct?

generators/numbers/annotator_split/config.py
"variables": {
"ATTRIBUTE": {
"selectionType": SelectionType.CHOICE.value,
"description": "only text fields",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This brick doesn't require input.

@LeonardPuettmannKern LeonardPuettmannKern changed the title New branch Random_int Annotator split Sep 25, 2023
@FelixKirschKern FelixKirschKern marked this pull request as draft October 18, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonardPuettmannKern LeonardPuettmannKern LeonardPuettmannKern requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SvenjaKern @LeonardPuettmannKern