Skip to content

Email cleaner #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Email cleaner #335

wants to merge 6 commits into from

Conversation

SvenjaKern
Copy link
Contributor

@SvenjaKern SvenjaKern commented Aug 31, 2023 •
edited
Loading

PR checklist:

  • Tested by creator on localhost:8000/docs
  • Tested by creator on refinery
  • Tested by reviewer on localhost:8000/docs
  • Tested by reviewer on refinery
  • (If added) common code tested in notebook/ script
  • Conforms with the agreed upon code pattern

LeonardPuettmannKern
LeonardPuettmannKern requested changes Sep 15, 2023
View reviewed changes
generators/__init__.py
Comment on lines +15 to +18
from .numbers import (
annotator_split
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be in this PR

generators/text_cleaning/email_cleaner/code_snippet_refinery.md
```python
import re

ATTRIBUTE: str = "headline" #only text attributes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change headline to text please.

generators/text_cleaning/email_cleaner/README.md
@@ -0,0 +1 @@
This modules removes certain aspects of the email to focus on the context. The aspects being removed are Sentences starting with "EXTERNAL MAIL", Brackets, that starts with "cid.image", everything after the Disclaimer or until the next Mail in case of response-mails and everything after the signiture in brackets or until the next Mail.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typos

Suggested change
This modules removes certain aspects of the email to focus on the context. The aspects being removed are Sentences starting with "EXTERNAL MAIL", Brackets, that starts with "cid.image", everything after the Disclaimer or until the next Mail in case of response-mails and everything after the signiture in brackets or until the next Mail.
This module removes certain aspects of the email to focus on the context. The aspects being removed are sentences starting with "EXTERNAL MAIL", brackets, that start with "cid.image", everything after the disclaimer or until the next mail in case of response mail, and everything after the signature in brackets or until the next mail.

@FelixKirschKern FelixKirschKern marked this pull request as draft October 18, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonardPuettmannKern LeonardPuettmannKern LeonardPuettmannKern requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SvenjaKern @LeonardPuettmannKern