Chat Sharing #200
Open
Chat Sharing #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JWittmeyer
reviewed
Nov 4, 2025
| def get_all_team_members_by_project(project_id: str) -> List[User]: | ||
| query = ( | ||
| session.query(User) | ||
| .join(TeamMember, TeamMember.user_id == User.id) |
There was a problem hiding this comment.
i think we only want the user_id here so not needed to join with user or is this used for something else as well?
JWittmeyer
reviewed
Nov 4, 2025
| ) | ||
|
|
||
|
|
||
| def get_by_conversation(conversation_id: str) -> List[ConversationGlobalShare]: |
JWittmeyer
reviewed
Nov 4, 2025
Comment on lines
+48
to
+49
| if with_commit: | ||
| session.commit() |
There was a problem hiding this comment.
general.flush_or_commit(with_commit)
JWittmeyer
reviewed
Nov 4, 2025
| session.commit() | ||
|
|
||
|
|
||
| def get_by_user(project_id: str, user_id: str) -> List[ConversationGlobalShare]: |
JWittmeyer
reviewed
Nov 4, 2025
|
|
||
| for share in existing_shares: | ||
| if share.shared_with not in shared_with_set: | ||
| session.delete(share) |
There was a problem hiding this comment.
we usually dont use the session object directly for this
JWittmeyer
reviewed
Nov 4, 2025
Comment on lines
+136
to
+147
| shares = [] | ||
|
|
||
| for user_id in shared_with_user_ids: | ||
| share = ConversationShare( | ||
| conversation_id=conversation_id, | ||
| shared_with=user_id, | ||
| shared_by=shared_by, | ||
| can_copy=can_copy, | ||
| ) | ||
| general.add(share, with_commit=False) | ||
| shares.append(share) | ||
|
|
There was a problem hiding this comment.
Suggested change
| shares = [] | |
| for user_id in shared_with_user_ids: | |
| share = ConversationShare( | |
| conversation_id=conversation_id, | |
| shared_with=user_id, | |
| shared_by=shared_by, | |
| can_copy=can_copy, | |
| ) | |
| general.add(share, with_commit=False) | |
| shares.append(share) | |
| general.add_all([ConversationShare( | |
| conversation_id=conversation_id, | |
| shared_with=user_id, | |
| shared_by=shared_by, | |
| can_copy=can_copy, | |
| ) for user_id in shared_with_user_ids, with_commit=True) | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main PR:
https://github.com/code-kern-ai/cognition-gateway/pull/277