Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update to new eslint vitest plugin #986

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Conversation

matejchalk
Copy link
Collaborator

Follow-up from code-pushup/eslint-config#37.

Fixes warning from npm install:

npm warn ERESOLVE overriding peer dependency
npm warn While resolving: @typescript-eslint/[email protected]
npm warn Found: eslint@9.16.0
npm warn node_modules/eslint
npm warn eslint@"^9.16.0" from the root project
npm warn 27 more (@code-pushup/eslint-config, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer eslint@"^8.56.0" from @typescript-eslint/[email protected]
npm warn node_modules/eslint-plugin-vitest/node_modules/@typescript-eslint/utils
npm warn @typescript-eslint/utils@"^7.7.1" from [email protected]
npm warn node_modules/eslint-plugin-vitest
npm warn
npm warn Conflicting peer dependency: [email protected]
npm warn node_modules/eslint
npm warn peer eslint@"^8.56.0" from @typescript-eslint/utils@7.18.0
npm warn node_modules/eslint-plugin-vitest/node_modules/@typescript-eslint/utils
npm warn @typescript-eslint/utils@"^7.7.1" from [email protected]
npm warn node_modules/eslint-plugin-vitest

Copy link

github-actions bot commented Apr 2, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit bf6c6d1 with previous commit 137392e.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 47 🔴 49 ↑ +2.6
Code coverage 🟢 90 🟢 90 ↑ +0.1
Security 🟡 62 🟡 62
Updates 🟡 84 🟡 84
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
Documentation 🔴 23 🔴 23
👍 2 groups improved, 👍 6 audits improved, 👎 1 audit regressed, 11 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 47 🔴 49 ↑ +2.6
Code coverage Code coverage metrics 🟢 90 🟢 90 ↑ +0.1

19 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟩 Root document took 560 ms 🟥 Root document took 1,800 ms ↑ +218.3 %
Lighthouse Time to Interactive 🟥 15.9 s 🟥 13.1 s ↓ −17.4 %
Lighthouse Speed Index 🟥 8.3 s 🟥 7.7 s ↓ −6.6 %
Lighthouse Largest Contentful Paint 🟨 3.7 s 🟨 3.5 s ↓ −4.1 %
Lighthouse Total Blocking Time 🟥 7,780 ms 🟥 2,900 ms ↓ −62.8 %
Lighthouse First Contentful Paint 🟨 2.9 s 🟨 2.9 s ↓ −2.3 %
Code coverage Line coverage 🟨 89.8 % 🟨 89.8 % ↑ +0.1 %
Lighthouse Minimizes main-thread work 🟥 22.1 s 🟥 13.5 s ↓ −39 %
Lighthouse JavaScript execution time 🟥 10.0 s 🟥 6.4 s ↓ −36.6 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −17.4 %
Lighthouse Max Potential First Input Delay 🟥 3,290 ms 🟥 1,710 ms ↓ −48.1 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 210 ms 🟥 Potential savings of 810 ms ↑ +276.2 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,838 KiB 🟩 Total size was 1,838 KiB ↑ +0.1 %
Lighthouse Server Backend Latencies 🟩 260 ms 🟩 220 ms ↓ −17.6 %
Lighthouse Network Round Trip Times 🟩 80 ms 🟩 70 ms ↓ −3.1 %
JS Packages Outdated NPM dev dependencies. 🟨 53 outdated package versions (27 major, 19 minor, 6 patch, 1 prerelease) 🟨 52 outdated package versions (27 major, 18 minor, 6 patch, 1 prerelease) ↓ −1.9 %
Lighthouse Avoids an excessive DOM size 🟥 2,153 elements 🟥 2,152 elements ↓ −0.1 %

579 other audits are unchanged.

@matejchalk matejchalk merged commit d67d97c into main Apr 2, 2025
15 of 16 checks passed
@matejchalk matejchalk deleted the eslint-vitest-update branch April 2, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants