-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(plugin-skills): integrate plugin skills into skill system #784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
- Add 'plugin' to SkillScope type with highest priority (7) - Add pluginSkills option to MergeSkillsOptions interface - Add pluginSkills option to SkillResolutionOptions interface - Update resolveSkillContent to check plugin skills first - Update resolveMultipleSkills to check plugin skills first - Add 'plugin' to CommandScope for slashcommand compatibility - Add 8 new tests for plugin skill resolution
- Add pluginSkills parameter to SisyphusTaskToolOptions - Update createSisyphusTask to pass pluginSkills to resolveMultipleSkills - Update error message to include plugin skill names - Add pluginSkills parameter to buildAgent and createBuiltinAgents - Convert plugin commands to LoadedSkill format in config-handler - Update mergeSkills to accept and merge plugin skills with highest priority (7)
- Add try/catch for plugin skill loading in index.ts - Remove unnecessary comments in config-handler.ts - Update JSON schema from build
|
All contributors have signed the CLA. Thank you! ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a6d1abdbb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 9 files
Confidence score: 3/5
- Merging plugin metadata after applying the disable list in
src/features/opencode-skill-loader/merger.tscan re-enable previously blocked skills, so user-facing configurations may silently regress. - The issue is well understood and should be straightforward to fix, but until the merge order changes, the configuration safety net isn’t reliable.
- Pay close attention to
src/features/opencode-skill-loader/merger.ts– plugin merge order currently overrides the disable list.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="src/features/opencode-skill-loader/merger.ts">
<violation number="1" location="src/features/opencode-skill-loader/merger.ts:259">
P2: Disabled skills can be reintroduced because plugins are merged after the disable list is applied</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="src/features/opencode-skill-loader/merger.ts">
<violation number="1" location="src/features/opencode-skill-loader/merger.ts:264">
P2: Per-entry disables (`entries[name]=false`/`entry.disable`) are applied before plugin skills are merged, so a plugin skill with the same name can be re-added and bypass the disable.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Summary
pluginscope to skill system, enabling external plugins to register skillssisyphus_taskand agent skill injectionChanges
Types - Add plugin scope
Files:
src/features/opencode-skill-loader/types.ts,src/tools/slashcommand/types.tsAdded
plugintoSkillScopeandCommandScopeunion types.Skill Resolution - Support plugin skills lookup
File:
src/features/opencode-skill-loader/skill-content.tsresolveSkillContentandresolveMultipleSkillsnow acceptpluginSkillsoption to resolve plugin-provided skills.Skill Merging - Plugin skills priority
File:
src/features/opencode-skill-loader/merger.tsmergeSkillsintegrates plugin skills with proper priority ordering. Plugin scope has highest priority (7).Agent Utils - Pass plugin skills for skill injection
File:
src/agents/utils.tsbuildAgentandcreateBuiltinAgentsnow accept and passpluginSkillsparameter for agent skill injection.Sisyphus Task - Plugin skills in task delegation
File:
src/tools/sisyphus-task/tools.tsPlugin skills available in task delegation. Error messages now include plugin skill names in available list.
Plugin Loaders - Load plugin skills
Files:
src/index.ts,src/plugin-handlers/config-handler.tsPlugin skills loaded via
discoverInstalledPluginsandloadPluginSkillsAsCommands, then passed to relevant functions.Testing
bun run typecheckpassesskill-content.test.tsSummary by cubic
Integrates plugin-provided skills into the skill system so plugins can register skills that resolve across agents and tasks and override other sources.
Written for commit 46d7a2e. Summary will update on new commits.