Skip to content

[pull] main from firecrawl:main #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
Jan 21, 2026
Merged

[pull] main from firecrawl:main #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f94bdad
chore: log mismatch as warning
amplitudesxd Jan 21, 2026
3673753
feat: request timeout parameter min (#2710)
delong3 Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/api/src/controllers/v1/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ const baseScrapeOptions = z.strictObject({
.transform(tags => tags.map(transformIframeSelector))
.optional(),
onlyMainContent: z.boolean().prefault(true),
timeout: z.int().positive().finite().optional(),
timeout: z.int().positive().min(1000).optional(),
waitFor: z.int().nonnegative().finite().max(60000).prefault(0),
// Deprecate this to jsonOptions
extract: extractOptions.optional(),
Expand Down Expand Up @@ -719,7 +719,7 @@ const extractV1Options = z
origin: z.string().optional().prefault("api"),
integration: integrationSchema.optional().transform(val => val || null),
urlTrace: z.boolean().prefault(false),
timeout: z.int().positive().finite().prefault(60000),
timeout: z.int().positive().min(1000).prefault(60000),
__experimental_streamSteps: z.boolean().prefault(false),
__experimental_llmUsage: z.boolean().prefault(false),
__experimental_showSources: z.boolean().prefault(false),
Expand Down Expand Up @@ -780,7 +780,7 @@ const scrapeRequestSchemaBase = baseScrapeOptions
jsonOptions: extractOptionsWithAgent.optional(),
origin: z.string().optional().prefault("api"),
integration: integrationSchema.optional().transform(val => val || null),
timeout: z.int().positive().finite().prefault(30000),
timeout: z.int().positive().min(1000).prefault(30000),
zeroDataRetention: z.boolean().optional(),
})
.strict();
Expand Down
6 changes: 3 additions & 3 deletions apps/api/src/controllers/v2/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,8 +528,8 @@ const baseScrapeOptions = z.strictObject({
.transform(tags => tags.map(transformIframeSelector))
.optional(),
onlyMainContent: z.boolean().prefault(true),
timeout: z.int().positive().finite().optional(),
waitFor: z.int().nonnegative().finite().max(60000).prefault(0),
timeout: z.int().positive().min(1000).optional(),
waitFor: z.int().nonnegative().max(60000).prefault(0),
mobile: z.boolean().prefault(false),
parsers: parsersSchema.optional(),
actions: actionsSchema.optional(),
Expand Down Expand Up @@ -679,7 +679,7 @@ const extractOptions = z
origin: z.string().optional().prefault("api"),
integration: integrationSchema.optional().transform(val => val || null),
urlTrace: z.boolean().prefault(false),
timeout: z.int().positive().finite().optional(),
timeout: z.int().positive().min(1000).optional(),
agent: agentOptionsExtract.optional(),
__experimental_streamSteps: z.boolean().prefault(false),
__experimental_llmUsage: z.boolean().prefault(false),
Expand Down
2 changes: 1 addition & 1 deletion apps/api/src/services/ab-test-comparison.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export function scheduleABComparison(
},
);
} else {
abLogger.info(`${AB_LOG_PREFIX} Content mismatch (${timeDiffStr})`, {
abLogger.warn(`${AB_LOG_PREFIX} Content mismatch (${timeDiffStr})`, {
...baseLogData,
prod_len: prodMarkdown.length,
mirror_len: mirrorMarkdown.length,
Expand Down
Loading