[pull] main from TryGhost:main #852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…testing (#25870) closes https://linear.app/ghost/issue/NY-921 - To test performance we made it so member welcome emails would go to a fake inbox, even if the labs flag wasn't set and the content wasn't set up. This PR removes that code. (effectively reverts #25802) - Now, to add to outbox and send an email the following must be true: 1) `memberWelcomeEmailTestInbox` exists in config, because we haven't toggled on real email sending just yet, and 2) particular welcome email (free or paid) exists, and has lexical content, and status is active.
ref https://linear.app/ghost/issue/NY-849/editor-for-welcome-emails-should-be-restricted ref https://linear.app/ghost/issue/NY-859/editor-does-not-allow-deleting-list-items This updates the Koenig editor used for editing member welcome emails in the settings UI. It restricts the nodes that can be added to the editor to a bare minimum set, and also fixes the deleting of list items by ensuring the right plugins are installed in the editor. --- Note: this does not use the new `KoenigEmailEditor` component from Koenig, because doing so resulted in quite a bit of duplication of code between `admin-x-framework` and the existing `koenig-editor-base` from `admin-x-design-system`. We may revisit the `KoenigEmailEditor` component soon as it does have some advantages in terms of maintainability, but considering that out of scope for this change. --------- Co-authored-by: Steve Larson <[email protected]> Co-authored-by: Cursor Agent <[email protected]> Co-authored-by: Troy Ciesco <[email protected]>
ref https://linear.app/ghost/issue/NY-912 closes https://linear.app/ghost/issue/NY-847 - Fixes the hierarchical styling for h2 and h3 headings in the member welcome email editor, while maintaining the inherited font styles for html editors (like the announcements bar) - Makes various member welcome email elements visible in dark mode that weren't before; may still need some final style tweaks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )