[pull] main from TryGhost:main #855
Merged
+188
−573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref https://linear.app/ghost/issue/FEA-509/ We shouldn't need to pay the network and CPU cost of loading the Featurebase script until we actually need it to display the Feedback widget. - Delayed Featurebase SDK loading and JWT token fetching until the user interacts with the Feedback button - Added preloading on hover/focus to hide latency while avoiding unnecessary page load overhead - Clicks will wait for all preloading to finish (starting if not already started) before opening the feedback modal
no issue - the email size warning was appearing unnecessarily on pages and old published posts - added additional conditions to the warning being enabled: - pages - these can't be emailed - published posts - must be unpublished in order to email, at which point warning will show in the publish flow
ref https://linear.app/ghost/issue/ONC-1396/ The email size warning service made a browse request to `/newsletters/` on the Admin API in order to pass a newsletter id to the email preview endpoint but Contributors don't have permissions to access the newsletters endpoints resulting in a 403 network error and the email size warning silently failing. - reviewing the email preview endpoint shows it already fetches the default newsletter when one isn't provided - removed all newsletter fetching/passing code from the email size warning service thereby removing a request, fixing the 403 error noise, and enabling the feature to work for Contributors
ref https://linear.app/ghost/issue/DES-1270/member-activity-item-hover-state-issues The background colour wasn't working. The transparency for the borders would work and the list would look broken. | Before | After | |--------|--------| | <img width="777" height="236" alt="Screenshot 2026-01-19 at 14 08 47" src="https://github.com/user-attachments/assets/081a4f88-5373-4f93-999d-6f435e8854f1" /> |<img width="856" height="232" alt="Screenshot 2026-01-19 at 14 08 11" src="https://github.com/user-attachments/assets/f79adb92-d99b-4422-92f7-39563248a03d" /> |
closes [GVA-640](https://linear.app/ghost/issue/GVA-640/remove-labs-flag-for-domain-warming) Removing the labs flag makes this generally available, configurable with the `fallbackAddress` and `fallbackDomain` options (which are required to be able to warm-up the primary domain).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )