Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .cursor/rules/novu.mdc
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,6 @@ When writing FrontEnd code, you are an expert on modern dev tool UI and UX desig
### Git Rules
- when adding commit titles, use proper scope (dashboard,web,api,worker,shared,etc...)

### Pull Request Rules
- When creating a pull request, use the following format semantic format for semantic pr title:
- Title: fix([scope]): [description] (e.g. feat(dashboard): add new feature)
- Description: A detailed description of the changes made in the pull request
- If working on a linear issue, add fixes NV-<issue-number> to the title end

### Key Conventions
- Linting: Add blank lines before return statements
- When importing "motion-react" package, import it from "motion/react"
10 changes: 10 additions & 0 deletions .cursor/rules/pullrequest.mdc
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
description: When creating a new pull request on GitHub, use this to specifiy the contents
alwaysApply: false
---

### Pull Request Rules
- When creating a pull request, use the following format semantic format for semantic pr title:
- Title: fix([scope]): [description] (e.g. feat(dashboard): add new feature)
- Description: A detailed description of the changes made in the pull request
- If working on a linear issue, add fixes NV-<issue-number> to the title end
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export abstract class BaseTranslationRendererUsecase {
resourceEntity?: NotificationTemplateEntity | LayoutDto;
organization?: OrganizationEntity;
}): Promise<Record<string, unknown>> {
if (process.env.NOVU_ENTERPRISE !== 'true') {
if (process.env.NOVU_ENTERPRISE !== 'true' && process.env.CI_EE_TEST !== 'true') {
return controls;
}

Expand Down Expand Up @@ -76,7 +76,7 @@ export abstract class BaseTranslationRendererUsecase {
locale?: string;
organization?: OrganizationEntity;
}): Promise<string> {
if (process.env.NOVU_ENTERPRISE !== 'true') {
if (process.env.NOVU_ENTERPRISE !== 'true' && process.env.CI_EE_TEST !== 'true') {
return content;
}

Expand Down Expand Up @@ -109,7 +109,7 @@ export abstract class BaseTranslationRendererUsecase {
organization?: OrganizationEntity;
resourceEntity?: NotificationTemplateEntity | LayoutDto;
}): Promise<TranslationContext | null> {
if (process.env.NOVU_ENTERPRISE !== 'true') {
if (process.env.NOVU_ENTERPRISE !== 'true' && process.env.CI_EE_TEST !== 'true') {
return null;
}

Expand Down Expand Up @@ -165,7 +165,7 @@ export abstract class BaseTranslationRendererUsecase {
content: string;
variables: FullPayloadForRender;
}): Promise<string> {
if (process.env.NOVU_ENTERPRISE !== 'true' || !context) {
if ((process.env.NOVU_ENTERPRISE !== 'true' && process.env.CI_EE_TEST !== 'true') || !context) {
return content;
}

Expand Down
Loading
Loading