[pull] main from tinacms:main #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request fixes an issue where the selected package manager was not being properly captured in telemetry when passed as a parameter in `create-tina-app`. **Telemetry data handling improvements:** * Ensured the selected package manager is always captured in telemetry, regardless of how it is provided (either as a parameter or through user input). (.changeset/neat-masks-rhyme.md, [packages/create-tina-app/src/index.tsL255-R256](diffhunk://#diff-ac1b8c916251d9122d94fbf42933af2d6829962fb0a80ab6d68fa462a9225e44L255-R256)) * Standardized the way telemetry data is sent by removing redundant or inconsistent inclusion of `template`, `theme`, and `package_manager` properties in the `additionalProperties` object, instead relying on the consolidated `telemetryData` object. [[1]](diffhunk://#diff-ac1b8c916251d9122d94fbf42933af2d6829962fb0a80ab6d68fa462a9225e44L367-R367) [[2]](diffhunk://#diff-ac1b8c916251d9122d94fbf42933af2d6829962fb0a80ab6d68fa462a9225e44L389-R394) [[3]](diffhunk://#diff-ac1b8c916251d9122d94fbf42933af2d6829962fb0a80ab6d68fa462a9225e44L420-R415) [[4]](diffhunk://#diff-ac1b8c916251d9122d94fbf42933af2d6829962fb0a80ab6d68fa462a9225e44L443-R434) [[5]](diffhunk://#diff-ac1b8c916251d9122d94fbf42933af2d6829962fb0a80ab6d68fa462a9225e44L465-R452) **Bug fix:** * Fixed a bug where the selected package manager was incorrectly assigned to the `provided_template` property instead of `package-manager` in telemetry events. **Minor enhancement:** * Added the selected theme to telemetry data when a theme is chosen.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )