[pull] main from microsoft:main #809
Merged
+1,663
−165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix missing stop button after elicitation is hidden Fix #283328 * Set elicitation state to rejected when hidden * Only reject when it was pending
fix build
…ypus Add searchable option groups for chat sessions
…87186) - _onDidChangeToolsScheduler.isScheduled is checked to avoid thrashing setTimeout when disposing many tools - WorkspaceExtensionsManagementService was listening to file change events using a debounce. Debounces have overhead because a new timer is scheduled on every single call. For large amount of file changes (during EH shutdown when schemas for tools are deregistered) this caused a notable slowdown. `throttle` should be functionally equivalent. - avoid triggering input updates (w/ downstream editor effects) each time the input gets parsed, which happened every time tool is called - big hammer -- don't bother deregistering MCP tools each time Results: - `216ms` to shut down EH before making these changes - `87ms` in the first three bullets - `54ms` after skipping MCP tool deregistering. (Basically all the overhead there was unregistering the JSON schema for tool inputs.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )