[pull] main from microsoft:main #832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial plan * Fix default log level not applied to extensions correctly The issue was in extHostOutput.ts where getLogLevel() always returns a value (never undefined) because it falls back to the global default. This was overriding the extension-specific default log level. Changed to only override if there's an explicitly set log level for that logger resource using getRegisteredLogger() which returns the ILoggerResource with logLevel as undefined when using default. Co-authored-by: ulugbekna <16353531+ulugbekna@users.noreply.github.com> * Improve comment clarity based on code review feedback Co-authored-by: ulugbekna <16353531+ulugbekna@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ulugbekna <16353531+ulugbekna@users.noreply.github.com>
…88427) * Initial plan * Fix: convert query to revealSetting when opening JSON settings editor Co-authored-by: sandy081 <10746682+sandy081@users.noreply.github.com> * Check for @id: prefix before using query as setting key Co-authored-by: sandy081 <10746682+sandy081@users.noreply.github.com> * Remove build-output.log and add to gitignore Co-authored-by: sandy081 <10746682+sandy081@users.noreply.github.com> * clean up --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: sandy081 <10746682+sandy081@users.noreply.github.com> Co-authored-by: Sandeep Somavarapu <sasomava@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )