Conversation
…e processed immediately (#292846) * Refactor view model to directly receive model events Simplify how the view model receives and processes model events by establishing a more direct connection between the model and view model layers. Co-authored-by: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com> * Fix post-merge errors * Add jsdoc comments * Fix cursor position during undo/redo with immediate viewModel events Pass resultingSelection through the call chain during undo/redo: - _applyUndoRedoEdits -> _doApplyEdits -> _emitContentChangedEvent This ensures viewModels receive the correct cursor selection immediately when processing content changes, rather than falling back to marker recovery which places the cursor at the end of inserted text. Fixes issue #42783 * Update src/vs/editor/test/browser/viewModel/viewModelImpl.test.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/vs/editor/test/common/model/model.test.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix formatting --------- Co-authored-by: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…9457) * vscode-dts: Add LineCommentConfig interface & update lineComment * rename config to rule --------- Co-authored-by: Aiday Marlen Kyzy <aidaymarlenkyzy@gmail.com>
* do not update agent status inicator bg color when debugging * actually this * Add themeable agentStatusIndicator.background color to avoid debug override (#292944) * Initial plan * Add themeable agentStatusIndicator.background color to avoid debug override Co-authored-by: joshspicer <23246594+joshspicer@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: joshspicer <23246594+joshspicer@users.noreply.github.com> * update known variables --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
* Fix typo: accomodate -> accommodate Fix spelling of "accommodate" in comments across multiple files: - src/vs/editor/common/viewLayout/viewLayout.ts - src/vs/platform/files/node/watcher/parcel/parcelWatcher.ts - src/vs/workbench/common/editor/editorGroupModel.ts * fix: close file handle in getOSReleaseInfo to prevent resource leak The FileHandle opened for reading os-release files was never closed, which could lead to file descriptor leaks. Added a finally block to ensure the handle is properly closed regardless of success or error. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )