Conversation
- Added check in TerminalSandboxService to filter out '*' wildcard when building allowedDomains list for sandbox - Sandbox runtime doesn't allow sole wildcard '*', but wildcards like '*.github.com' are OK - Added comprehensive unit tests covering various scenarios including wildcards, combinations, and deduplication Co-authored-by: jrieken <1794099+jrieken@users.noreply.github.com>
…tion Co-authored-by: jrieken <1794099+jrieken@users.noreply.github.com>
The TerminalSandboxService tests were failing because the mock environment service stub was missing the required _serviceBrand property. This property is mandatory for all service interfaces in VS Code's DI system. Co-authored-by: jrieken <1794099+jrieken@users.noreply.github.com>
The tests were failing on Windows because the sandbox service returns false from isEnabled() when running on Windows. Fixed by making MockRemoteAgentService return a Linux remote environment, simulating a remote connection which allows the tests to pass on all platforms. Co-authored-by: jrieken <1794099+jrieken@users.noreply.github.com>
* Display custom agents that only target VS Code or everything * Updates
…omains-setting Filter sole wildcard from allowTrustedDomains for sandbox compatibility
* Add compact toggle for activity bar in default position * Add size submenu for activity bar in default position * ccr --------- Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com> Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com> Co-authored-by: Alex Ross <38270282+alexr00@users.noreply.github.com>
Git - extract quick diff providers
* chore: bump electron@39.6.0 * chore: bump distro
…ia-guppy Update @vscode/codicons version to 0.0.45-8
…cker Hide edit mode is default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )