Conversation
- Chat session loads, katex has not yet been loaded - ListView really wants to render from the top down so it checks the heights of some elements at the top - Katex not loaded, so we don't render markdown at all - Measured element height is very wrong - But we initialize scroll all the way down so those elements don't get a chance to fix their height - When scrolling up, we render an element and it is resized massively from the previous estimate, content shifts down
* Bump xterm to enable kitty images * edit comment about gpu acceleration+kitty * Update to 162 * Update please * Mention enable transparency mode * Stop messing with git * Update to 165
Fix some jumping on scrolling up
* Browser: Managed CDP context groups * layering * feedback * Fail fast * two-way lookup * feedback, cleanup
* fix: crash with run_as_node in sub app * chore: bump distro
Disable buttons when not possible to use them
* perf: defer expensive repo diff capture to export time
Split repo info capture into two paths:
1. On first chat message (lightweight, no file I/O):
- captureRepoMetadata() reads only from already-loaded SCM
provider observables (branch name, commit hash, remote refs)
- Synchronous, zero file I/O, no diff computation
- Stores ~200 bytes of metadata per session
2. At export time only (on-demand, user-initiated):
- captureRepoInfo() performs full file reads and diff generation
- Only runs when user explicitly triggers 'Export Chat as Zip'
Additional changes:
- Remove repoData from toJSON() serialization. Repo state does not
need to survive VS Code restarts, only matters for current session
export. This eliminates serialization overhead in saveState().
- Remove trimOldSessionDiffs(). No longer needed since diffs are
never stored on the model.
- Remove IFileService dependency from ChatRepoInfoContribution
- Export action no longer gated on chat.repoInfo.enabled for diff
capture (always captures at export time since it is user-initiated)
Addresses feedback from #286812 about per-message overhead.
Fixes #294863 root cause (expensive file I/O on every message).
* fix: address PR review feedback
- Fix undefined === undefined falsely reporting 'synced' by requiring
both localHeadCommit and remoteHeadCommit to be defined
- Use 'local-git' / 'local-only' when no remote refs are available
instead of always claiming 'remote-git'
- Update setting description to reflect metadata-only capture
A/B experiment: close button vs Skip for now button on sign-in dialog Add experiment 'chatSetupDialogCloseButton' using IWorkbenchAssignmentService: - Treatment (true): show standard X close button, hide Skip for now button - Control (default): show Skip for now button, hide X close button Both variants produce the same 'failedMaybeLater' telemetry on dismiss. Test locally via: experiments.override.chatSetupDialogCloseButton: true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )