[pull] main from microsoft:main

examples/todomvc/tests/perform/completing-todos/should-complete-multiple-todos.spec.ts-cache.json

@@ -38,7 +38,6 @@
       {
         "method": "click",
         "selector": "internal:role=listitem >> internal:has-text=\"Buy milk\"i >> internal:label=\"Toggle Todo\"i",
-        "options": {},
         "code": "await page.getByRole('listitem').filter({ hasText: 'Buy milk' }).getByLabel('Toggle Todo').click();"
       }
     ]
@@ -48,7 +47,6 @@
       {
         "method": "click",
         "selector": "internal:role=listitem >> internal:has-text=\"Finish report\"i >> internal:label=\"Toggle Todo\"i",
-        "options": {},
         "code": "await page.getByRole('listitem').filter({ hasText: 'Finish report' }).getByLabel('Toggle Todo').click();"
       }
     ]
@@ -104,9 +102,8 @@
     "actions": [
       {
         "method": "expectVisible",
-        "selector": "internal:text=\"0 items left\"i",
-        "isNot": true,
-        "code": "await expect(page.getByText('0 items left')).not.toBeVisible();"
+        "selector": "internal:role=textbox[name=\"What needs to be done?\"i]",
+        "code": "await expect(page.getByRole('textbox', { name: 'What needs to be done?' })).toBeVisible();"
       }
     ]
   },

examples/todomvc/tests/perform/completing-todos/should-complete-single-todo.spec.ts-cache.json

@@ -15,7 +15,6 @@
       {
         "method": "click",
         "selector": "internal:role=checkbox[name=\"Toggle Todo\"i]",
-        "options": {},
         "code": "await page.getByRole('checkbox', { name: 'Toggle Todo' }).click();"
       }
     ]
@@ -62,18 +61,17 @@
     "actions": [
       {
         "method": "expectVisible",
-        "selector": "internal:role=list[name=\"Todo List\"i]",
-        "isNot": true,
-        "code": "await expect(page.getByRole('list', { name: 'Todo List' })).not.toBeVisible();"
+        "selector": "internal:role=textbox[name=\"What needs to be done?\"i]",
+        "code": "await expect(page.getByRole('textbox', { name: 'What needs to be done?' })).toBeVisible();"
       }
     ]
   },
   "The todo appears as active": {
     "actions": [
       {
         "method": "expectVisible",
-        "selector": "internal:text=\"Buy groceries\"i",
-        "code": "await expect(page.getByText('Buy groceries')).toBeVisible();"
+        "selector": "internal:role=generic[name=\"Buy groceries\"i]",
+        "code": "await expect(page.getByRole('generic', { name: 'Buy groceries' })).toBeVisible();"
       }
     ]
   }

examples/todomvc/tests/perform/completing-todos/should-toggle-all-todos-complete.spec.ts-cache.json

@@ -58,7 +58,6 @@
       {
         "method": "click",
         "selector": "internal:role=checkbox[name=\"❯Mark all as complete\"i]",
-        "options": {},
         "code": "await page.getByRole('checkbox', { name: '❯Mark all as complete' }).click();"
       }
     ]
@@ -91,6 +90,12 @@
     ]
   },
   "The page loads with an empty todo list": {
-    "actions": []
+    "actions": [
+      {
+        "method": "expectVisible",
+        "selector": "internal:role=textbox[name=\"What needs to be done?\"i]",
+        "code": "await expect(page.getByRole('textbox', { name: 'What needs to be done?' })).toBeVisible();"
+      }
+    ]
   }
 }

examples/todomvc/tests/perform/completing-todos/should-toggle-all-todos-incomplete.spec.ts-cache.json

@@ -23,10 +23,10 @@
         "code": "await page.getByRole('textbox', { name: 'What needs to be done?' }).fill('Task 3');\nawait page.keyboard.press('Enter');"
       },
       {
-        "method": "click",
+        "method": "setChecked",
         "selector": "internal:role=checkbox[name=\"❯Mark all as complete\"i]",
-        "options": {},
-        "code": "await page.getByRole('checkbox', { name: '❯Mark all as complete' }).click();"
+        "checked": true,
+        "code": "await page.getByRole('checkbox', { name: '❯Mark all as complete' }).check();"
       }
     ]
   },
@@ -38,15 +38,32 @@
         "type": "checkbox",
         "value": "false",
         "code": "await expect(page.getByRole('listitem').filter({ hasText: 'Task 1' }).getByLabel('Toggle Todo')).toBeChecked({ checked: false });"
+      },
+      {
+        "method": "expectValue",
+        "selector": "internal:role=listitem >> internal:has-text=\"Task 2\"i >> internal:label=\"Toggle Todo\"i",
+        "type": "checkbox",
+        "value": "false",
+        "code": "await expect(page.getByRole('listitem').filter({ hasText: 'Task 2' }).getByLabel('Toggle Todo')).toBeChecked({ checked: false });"
+      },
+      {
+        "method": "expectValue",
+        "selector": "internal:role=listitem >> internal:has-text=\"Task 3\"i >> internal:label=\"Toggle Todo\"i",
+        "type": "checkbox",
+        "value": "false",
+        "code": "await expect(page.getByRole('listitem').filter({ hasText: 'Task 3' }).getByLabel('Toggle Todo')).toBeChecked({ checked: false });"
       }
     ]
   },
   "All todos are marked as active": {
     "actions": [
       {
-        "method": "expectVisible",
-        "selector": "internal:text=\"3 items left\"i",
-        "code": "await expect(page.getByText('3 items left')).toBeVisible();"
+        "method": "expectValue",
+        "selector": "internal:role=listitem >> internal:has-text=\"Task 1\"i >> internal:label=\"Toggle Todo\"i",
+        "type": "checkbox",
+        "value": "false",
+        "isNot": false,
+        "code": "await expect(page.getByRole('listitem').filter({ hasText: 'Task 1' }).getByLabel('Toggle Todo')).toBeChecked({ checked: false });"
       }
     ]
   },
@@ -58,6 +75,20 @@
         "type": "checkbox",
         "value": "true",
         "code": "await expect(page.getByRole('listitem').filter({ hasText: 'Task 1' }).getByLabel('Toggle Todo')).toBeChecked({ checked: true });"
+      },
+      {
+        "method": "expectValue",
+        "selector": "internal:role=listitem >> internal:has-text=\"Task 2\"i >> internal:label=\"Toggle Todo\"i",
+        "type": "checkbox",
+        "value": "true",
+        "code": "await expect(page.getByRole('listitem').filter({ hasText: 'Task 2' }).getByLabel('Toggle Todo')).toBeChecked({ checked: true });"
+      },
+      {
+        "method": "expectValue",
+        "selector": "internal:role=listitem >> internal:has-text=\"Task 3\"i >> internal:label=\"Toggle Todo\"i",
+        "type": "checkbox",
+        "value": "true",
+        "code": "await expect(page.getByRole('listitem').filter({ hasText: 'Task 3' }).getByLabel('Toggle Todo')).toBeChecked({ checked: true });"
       }
     ]
   },
@@ -66,7 +97,6 @@
       {
         "method": "click",
         "selector": "internal:role=checkbox[name=\"❯Mark all as complete\"i]",
-        "options": {},
         "code": "await page.getByRole('checkbox', { name: '❯Mark all as complete' }).click();"
       }
     ]

examples/todomvc/tests/perform/completing-todos/should-uncomplete-completed-todo.spec.ts-cache.json

@@ -11,7 +11,6 @@
       {
         "method": "click",
         "selector": "internal:role=checkbox[name=\"Toggle Todo\"i]",
-        "options": {},
         "code": "await page.getByRole('checkbox', { name: 'Toggle Todo' }).click();"
       }
     ]
@@ -21,7 +20,6 @@
       {
         "method": "click",
         "selector": "internal:role=checkbox[name=\"Toggle Todo\"i]",
-        "options": {},
         "code": "await page.getByRole('checkbox', { name: 'Toggle Todo' }).click();"
       }
     ]
@@ -39,8 +37,8 @@
     "actions": [
       {
         "method": "expectVisible",
-        "selector": "internal:text=\"item left\"i",
-        "code": "await expect(page.getByText('item left')).toBeVisible();"
+        "selector": "internal:text=\"1 item left\"i",
+        "code": "await expect(page.getByText('1 item left')).toBeVisible();"
       }
     ]
   },
@@ -69,8 +67,8 @@
     "actions": [
       {
         "method": "expectVisible",
-        "selector": "internal:role=textbox[name=\"What needs to be done?\"i]",
-        "code": "await expect(page.getByRole('textbox', { name: 'What needs to be done?' })).toBeVisible();"
+        "selector": "internal:text=\"What needs to be done?\"i",
+        "code": "await expect(page.getByText('What needs to be done?')).toBeVisible();"
       }
     ]
   },

examples/todomvc/tests/perform/deleting-todos/should-clear-all-completed-todos.spec.ts-cache.json

@@ -47,7 +47,6 @@
       {
         "method": "click",
         "selector": "internal:role=button[name=\"Clear completed\"i]",
-        "options": {},
         "code": "await page.getByRole('button', { name: 'Clear completed' }).click();"
       }
     ]
@@ -66,13 +65,11 @@
       {
         "method": "click",
         "selector": "internal:role=listitem >> internal:has-text=\"Task 1\"i >> internal:label=\"Toggle Todo\"i",
-        "options": {},
         "code": "await page.getByRole('listitem').filter({ hasText: 'Task 1' }).getByLabel('Toggle Todo').click();"
       },
       {
         "method": "click",
         "selector": "internal:role=listitem >> internal:has-text=\"Task 3\"i >> internal:label=\"Toggle Todo\"i",
-        "options": {},
         "code": "await page.getByRole('listitem').filter({ hasText: 'Task 3' }).getByLabel('Toggle Todo').click();"
       }
     ]
@@ -117,9 +114,18 @@
   "Two todos are marked as complete": {
     "actions": [
       {
-        "method": "expectVisible",
-        "selector": "internal:text=\"item left\"i",
-        "code": "await expect(page.getByText('item left')).toBeVisible();"
+        "method": "expectValue",
+        "selector": "internal:role=listitem >> internal:has-text=\"Task 1\"i >> internal:label=\"Toggle Todo\"i",
+        "type": "checkbox",
+        "value": "true",
+        "code": "await expect(page.getByRole('listitem').filter({ hasText: 'Task 1' }).getByLabel('Toggle Todo')).toBeChecked({ checked: true });"
+      },
+      {
+        "method": "expectValue",
+        "selector": "internal:role=listitem >> internal:has-text=\"Task 3\"i >> internal:label=\"Toggle Todo\"i",
+        "type": "checkbox",
+        "value": "true",
+        "code": "await expect(page.getByRole('listitem').filter({ hasText: 'Task 3' }).getByLabel('Toggle Todo')).toBeChecked({ checked: true });"
       }
     ]
   }

examples/todomvc/tests/perform/deleting-todos/should-delete-single-todo.spec.ts-cache.json

@@ -24,7 +24,6 @@
       {
         "method": "click",
         "selector": "internal:role=button[name=\"Delete\"i]",
-        "options": {},
         "code": "await page.getByRole('button', { name: 'Delete' }).click();"
       }
     ]
@@ -33,18 +32,17 @@
     "actions": [
       {
         "method": "expectVisible",
-        "selector": "internal:text=\"1 item left\"i",
-        "code": "await expect(page.getByText('1 item left')).toBeVisible();"
+        "selector": "internal:text=\"item left\"i",
+        "code": "await expect(page.getByText('item left')).toBeVisible();"
       }
     ]
   },
   "Hover over the todo item": {
     "actions": [
       {
         "method": "hover",
-        "selector": "internal:testid=[data-testid=\"todo-item\"s] >> div",
-        "options": {},
-        "code": "await page.getByTestId('todo-item').locator('div').hover();"
+        "selector": "internal:testid=[data-testid=\"todo-title\"s]",
+        "code": "await page.getByTestId('todo-title').hover();"
       }
     ]
   },
@@ -59,7 +57,14 @@
     ]
   },
   "The list is empty": {
-    "actions": []
+    "actions": [
+      {
+        "method": "expectVisible",
+        "selector": "internal:text=\"Task to delete\"i",
+        "isNot": true,
+        "code": "await expect(page.getByText('Task to delete')).not.toBeVisible();"
+      }
+    ]
   },
   "The page loads with an empty todo list": {
     "actions": [
@@ -83,8 +88,9 @@
     "actions": [
       {
         "method": "expectVisible",
-        "selector": "internal:role=textbox[name=\"What needs to be done?\"i]",
-        "code": "await expect(page.getByRole('textbox', { name: 'What needs to be done?' })).toBeVisible();"
+        "selector": "internal:text=\"Task to delete\"i",
+        "isNot": true,
+        "code": "await expect(page.getByText('Task to delete')).not.toBeVisible();"
       }
     ]
   }

examples/todomvc/tests/perform/deleting-todos/should-delete-specific-todo-from-multiple.spec.ts-cache.json

@@ -75,24 +75,23 @@
       {
         "method": "hover",
         "selector": "internal:role=listitem >> internal:has-text=\"Task 2\"i",
-        "options": {},
         "code": "await page.getByRole('listitem').filter({ hasText: 'Task 2' }).hover();"
       },
       {
         "method": "click",
         "selector": "internal:role=button[name=\"Delete\"i]",
-        "options": {},
         "code": "await page.getByRole('button', { name: 'Delete' }).click();"
       }
     ]
   },
   "The page loads with an empty todo list": {
     "actions": [
       {
-        "method": "expectVisible",
+        "method": "expectValue",
         "selector": "internal:role=textbox[name=\"What needs to be done?\"i]",
-        "isNot": false,
-        "code": "await expect(page.getByRole('textbox', { name: 'What needs to be done?' })).toBeVisible();"
+        "type": "textbox",
+        "value": "",
+        "code": "await expect(page.getByRole('textbox', { name: 'What needs to be done?' })).toHaveValue('');"
       }
     ]
   }

examples/todomvc/tests/perform/editing-todos/should-cancel-edit-on-escape.spec.ts-cache.json

@@ -12,17 +12,6 @@
   },
   "Change the text to 'Modified text' but press Escape instead of Enter": {
     "actions": [
-      {
-        "method": "click",
-        "selector": "internal:role=textbox[name=\"Edit\"i]",
-        "options": {},
-        "code": "await page.getByRole('textbox', { name: 'Edit' }).click();"
-      },
-      {
-        "method": "pressKey",
-        "key": "Control+a",
-        "code": "await page.keyboard.press('Control+a');"
-      },
       {
         "method": "fill",
         "selector": "internal:role=textbox[name=\"Edit\"i]",
@@ -50,9 +39,7 @@
       {
         "method": "click",
         "selector": "internal:testid=[data-testid=\"todo-title\"s]",
-        "options": {
-          "clickCount": 2
-        },
+        "clickCount": 2,
         "code": "await page.getByTestId('todo-title').click({\nclickCount: 2\n});"
       }
     ]
@@ -61,8 +48,8 @@
     "actions": [
       {
         "method": "expectVisible",
-        "selector": "internal:text=\"Original text\"i",
-        "code": "await expect(page.getByText('Original text')).toBeVisible();"
+        "selector": "internal:role=generic[name=\"Original text\"i]",
+        "code": "await expect(page.getByRole('generic', { name: 'Original text' })).toBeVisible();"
       }
     ]
   },