[pull] main from adobe:main #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: notification badge follow-up * remove notification badge if action button is disabled * remove label only quiet action button
* Fix generated code sample for S2 TooltipTrigger docs * review * inlining
…#7976) * Initial refactor to tear out UNSTABLE_portalContainer in favor of the PortalContainer * yarn.lock update * switch to deprecating UNSTABLE_portalContainer * prefer deprecated prop over context to make this a non-breaking change * add rough docs * updating copy to include explaination of UNSTABLE * rename to UNSAFE_PortalProvider * update copy and split out example * use styles from RAC examples --------- Co-authored-by: Robert Snow <[email protected]>
* Add disallowClearAll to Menu/ListBox so Autocomplete in Popover can close without clearing selection * add support for diallowClearAll to grid/tree/table * make sure RSP components also surface disallowClearAll * update api naming to escapeKeyBehavior * skip 17 tests for build, investigate later * review comments
* fix: minor typo in CalendarDate docs * fix second example as well --------- Co-authored-by: Robert Snow <[email protected]>
* chore: update typescript to 5.8 * fix all the types for the upgrade * fix numberfield styles
* fix: Apply touch-action by default in usePress * fix test --------- Co-authored-by: Daniel Lu <[email protected]>
* attempt to get rid of jest calls in menu util * update RSP testing docs to directly mention mocks that maybe needed * bump versions of RTL to 16 * use alternative to calling jest run timers in menu option selection * fixing types and properly testing long press * fix lint * revert to pre testing library bump for clean slate * fix build and another submenu edge case now we shouldnt need to call runAllTimers after selectOption * fix react 16 bug * update return type of advanceTimer and docs copy * move some general fixes from selectionMode="replace" branch here * get rid of unneeded async * getting rid of extraneous dep * fix lint
* fix: add static color to s2 notification badge * make opaque * updates * use locale * fix lint --------- Co-authored-by: Robert Snow <[email protected]>
* Latest translations * Translation correction * Couple of translation corrections * Remove å from Norwegian string --------- Co-authored-by: Yihui Liao <[email protected]>
…8006) Co-authored-by: Danni <[email protected]>
* chore: audit 3.41 * remove deprecation
* chore: audit 3.41 * remove deprecation
* wip * wip * tmp * update * wip * fix * fix * updates * fix * updates * wip * Move to css module * Accessibility improvements * Fixes and cleanup * more refinement * ts * exports * more cleanup * add intl * hide extra toast story to fix multiple toast container issue in docs was breaking animations * Move storybook config to be global * Only apply view transition classes when in a stack * Mark as unstable --------- Co-authored-by: Daniel Lu <[email protected]>
* chore: add notification badge to chromatic * fix lint
* chore: TS explicit module boundaries RSP 1 * card * checkbox * Color * combobox, contextualhelp, datepicker * dialog * divider, dropzone, form, icon, illustratedmessage, image * fix lint * inlinealert, label, labeledvalue, layout * link, list, listbox * menu * meter, numberfield, overlays, picker * progress, provider, radio * searchfield, slider, steplist, story-utils, switch * table * tabs, text, textfield, toast, tooltip * finish last tab * tree, view, well * revert source file changes * categorise all RAC stories
* fix: hcm progress circle * remove border width 3 * fix progress strokewidth
* fix: radio tab navigation in a focusscope * fix navigation inside RadioGroup * fix lint * build radio check into focusable tree walker so everyone benefits * make logic work outside a form as well * Update packages/@react-aria/focus/src/FocusScope.tsx Co-authored-by: Devon Govett <[email protected]> * add to dialog story for testing --------- Co-authored-by: Devon Govett <[email protected]>
…ptions and no selection (#8280) * fix: prevent form submission when required Select has more than 300 options and no selection * fix: only block form submission if the validation behavior is native * fix: lint errors * fix: prevent invalid form control error and native error popup for visually hidden required input * fix: prevent visually hidden text input from affecting keyboard navigation * refactor: use display: none instead of visually hidden to hide the input * fix conflict where select would steal focus on invalid from previous invalid components --------- Co-authored-by: Robert Snow <[email protected]> Co-authored-by: Robert Snow <[email protected]>
* chore: Pass through more DOM events and attributes * fix * fix test * Emit onClick from MenuItem * Add PressEvents to selectable items * Add PressEvents to toggles * fixes * weird batching difference in 17 tests? * fix * fix
…8397) * chore: TS explicit module S2 * fix any types in story * accidentally checked in tsconfig * tidy up * fix types for s2 TreeView * make two implementations align * fix types again * add pure * fix lint * undo changes to source * undo tsconfig change * fix story
… via IME (#8519) * feat: block onChange from firing until composition end this is for IMEs, we only want onChange to fire once the user has confirmed the final word/phrase they wanna enter * fix lint * fix extra onChange when deleting IME input deleting IME input is essentially cancelling it so it shouldnt trigger another onChange * review comments
* fix merge order in ColorArea and ColorSwatch * omit global dom attributes from S2
…collection size (#8349) * Update tree and listlayout to handle multi loaders * adapting other stories to new loader api and adding useAsync example story * add tests * fix story for correctness, should only need to provide a dependecy at the top most collection * restoring focus back to the tree if the user was focused on the loader * fixing estimated loader position if sections exist taken from #8326 * skip test for now * revert loader keyboard focus specific logic * pulling over relevant code from focus_loading_spinners * modify tree to return item count when querying size * update TableCollection to return just the number of rows as size also the aria row index and pos in set from empty/isLoading state wrapper since it might be confusing to hear that there are items when the table/tree is empty * update other collection components to leverage item only count * clean up * properly prevent picker from opening where there arent items * fix lint * review comments * review comments * making the async stories not load forever * docs: Async load more documentation for RAC (#8431) * add docs for gridlist * add async loading docs for GridList and Listbox adjacent components * add docs example for table * add prop tables * rename sentinel component and add prop tables * adding tree docs for loading spinners * fix docs lint * typo and left over stuff * export the loadMoreItem props from the monopackage * review comments * fix the tree example in docs * review comments * review comments * forgot to remove a delay * review comments
* useDrag: custom offset * allow passing getPreviewOffset into useDraggableCollectionState and useDragAndDrop * add stories for using with useDraggableCollectionState and useDragAndDrop * use renderDragPreview instead of getPreviewOffset
* use lucide-react for RAC example's icons * up contrast in CheckCircle in shipping-radio example * update icon in image-grid example * improve shopping-list example
* fix before-first drop indicator not showing * update useDndPersistedKeys to take level into account * update comment
* add hidden date input component * add stories * fix lint * fix story * add comments, fix types * add test (not finished) * fix types * add test * fix lint * review comments * add try catch
* fix: createLeafComponent ref typing * fix types * fix loading sentinel ref * update all refs
* feat: S2 DateField/DatePicker/Calendar * fix lint * start calendar * Style calendar and fix some datepicker styles * changing ring size * fix hover * revert outline size change * add range calendar * fix yarn lock * fix cell styles for different size ring and gap * add spectrum context * Add DateRangePicker * add comment * fix test * Add TimeField and aria labels * add press scaling * fix non-contiguous ranges styles * fix lint * remove explicit modules * Add time fields to date pickers * fix buttons in date picker popover * remove console log * fix storybook intermittent crash from implicit actions, scrolling * fix accessibility violation * review changes and deduplicating code * make outline in range smaller * Label instead of aria label the stories by default * reduce duplication, fix styles * remove added api for day/week index and add storybook decorators for calendar systems * field widths, share more * Add hcm support * add chromatic stories and fix bugs * remove problematic story * review fixes * test the range calendar more * review fixes * share helptext styles * add translations for everything and add default error messages * adjust props from all dom attributes * remove cellPadding from calendar grid
* chore: Update font and line heights to latest design * Include font loading in Provider * Add Hong Kong font and adjust weights for i18n fonts * Map CJK medium weight to bold instead of regular according to spectrum * update font URLs * Add fonts story to chromatic * fix chromatic * storybook is strange * Add CSS variable for font family * Update docs * add short selector keys
* initial commit * use react 19 and runtime automatic * use story types and remove extraneous My* exports * Share a few more components * make combobox like select * Share popovers/dialogs where possible * stop running extractExamples script * re-add script so we can run typescript on docs examples still * fix styles, use lucide icons, fix menu controls table * move to lucide icons, css fixes * fix examples * fix toggle button css * need to revert yarn.lock * revert yarn.lock * ignore yarn.lock again * update icons sizes to be smaller * make a few more icons smaller * share more between components and simplify, review comments * fix css selector * fix lint * small fixes --------- Co-authored-by: Devon Govett <[email protected]>
* add async loading support to S2 treeview * fix chevrons appearing on all tree items * fix treeview story docs * fix lint * readding isEmphasized and isDetached
* Revert "Revert "chore: Use inert in ariaHideOutside (#8317)" (#8371)" This reverts commit 26f9102. * Fix focus ring appearing on S2 submenus * Fix firefox focusing Picker/Menu items when clicking with mouse * Fix dialog re-focusing with iOS VO * Revert "Fix firefox focusing Picker/Menu items when clicking with mouse" This reverts commit 34bc815. --------- Co-authored-by: Daniel Lu <[email protected]>
This reverts commit f6d2eac.
- Allow setting the crossOrigin prop on the Image component - Added unit tests - Fixes #8531
* chore: make module boundaries explicit * fix s2 illustrations * fix lint and ts for React 18/19 * fix 16, 17 * fix return types to work with isolated modules for renderOverrides * fix inference * chore: ts explicit module boundary RAC * remove the harder to deal with satisfies * revert changes to source * fix story * add back in loader fixes * fix copy-pasta * fix lint * review comments * fix lint * fix story types
* chore: pin rollup version and use bigger resource class * use bigger resource class for test esm
* fix(XI-7052): Support text wrapping in vertical TabList * Add storybook * fix focus ring size and make sure it works in S2 --------- Co-authored-by: Robert Snow <[email protected]> Co-authored-by: Robert Snow <[email protected]> Co-authored-by: Daniel Lu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )