[pull] master from supabase:master #639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<img width="1196" height="427" alt="image" src="https://github.com/user-attachments/assets/6784b5e9-99c8-4fc9-b9f5-49672ba6e768" /> This reworks the security section within our project creation form to expose two options. 1/ Enable or disable Data API which is essentially the same as we had previously, just reframed 2/ Enable auto RLS which creates an event trigger that enables RLS on all tables created via public schema. This is the same as what we do via the RLS banner in authentication pages. Note that this also removes the option to disable Data API on public schema and move to dedicated schema. The user can still do this post project creation . Assumption is this is rarely changed on project creation and adds complexity. To test: 1. Create a new project 2. Enable Data API and enable RLS setting 3. After project creation, go to triggers -> event tab -> notice enable rls trigger 4. Create project and disable Data API 5. After project creation , go to settings/api and make sure data api is disabled <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added an optional automatic Row-Level Security (RLS) event trigger option in project creation (toggleable via experiment). * **Improvements** * Security panel simplified to checkbox-based controls for Data API and RLS. * Project creation form now includes the enableRlsEventTrigger flag and applies related setup when enabled. * Telemetry records RLS experiment exposure, variant, and whether the RLS trigger was enabled. * Free-project messaging updated to consider user limits. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Charis Lam <[email protected]> Co-authored-by: Sean Oliver <[email protected]>
- adds s3 log drain form - fixes issue tabbing over inputs to test you can create an s3 bucket in a aws account, create some credentials and try it, however I've tested it already and the logs reach S3 just fine. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added Amazon S3 as a new log drain destination with configuration for bucket, region, access credentials, and batch timeout settings. * **Documentation** * Updated guide documentation to include the new S3 destination alongside existing options and standardized Datadog terminology. * **Improvements** * Simplified error message rendering in form layouts for improved performance. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Ali Waseem <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…#42281) ## Context Addresses a UX confusion where users are unsure of which schema to install database extensions in. Am opting to show a "Default" badge on the extensions schema just to lower the cognitive load for this step if the extension doesn't have a specific schema it needs to be installed in <img width="416" height="322" alt="image" src="https://github.com/user-attachments/assets/b938afdb-31d7-4e9f-a065-7b3b185ac8e1" /> If the extension has a recommended schema, we'll show a badge as well (Related [PR](#40968)) <img width="429" height="300" alt="image" src="https://github.com/user-attachments/assets/cf42bce3-a99c-4877-9d16-9f2013b91e16" /> Otherwise, if there's a fixed schema, then no badge <img width="427" height="283" alt="image" src="https://github.com/user-attachments/assets/608c0c4f-ea8e-4462-ad66-9e3b3bb43265" /> ## Other changes - Refactored `EnableExtensionModal` to use react hook form + Dialog component - Refactored checking of default schema to use React Query ## To test - [ ] Verify the UI changes - [ ] Verify that you can still enable / disable extensions - and ensure that they're being installed in the right schemas <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Enhanced extension enable dialog with form-driven schema selection, read-only default-schema display, and "create custom schema" flow * "Recommended" and "Default" badges next to schema choices; platform-specific warnings and callouts * Fetches and surfaces extension default/recommended schema to guide selection * **Refactor** * Dialog-based UI with integrated form validation and improved enable workflow <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Alaister Young <[email protected]>
github-actions
bot
added
the
documentation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )