Breadcrumbs - #51
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8feca0bd57
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (third === "projects") return fourth === "create" | ||
| if (third === "members") return fourth === "add" | ||
| if (third === "roles") return fourth === "create" | ||
| if (third === "runtimes") return fourth === "create" | ||
| if (third === projectIndex) return fourth === "@tabs" |
There was a problem hiding this comment.
Next.js parallel route segment names (like @tabs) do not appear in the URL returned by usePathname(), so for real URLs such as /namespace/:namespaceId/:projectId/flow the pathSegments array will never contain "@tabs". With the current checks, those paths are marked non-routable and resolveDestination trims them back to /namespace/:namespaceId/:projectId, causing breadcrumb entries for Flow (and flowId) pages to link to the project root instead of the current tab. This breaks breadcrumb navigation for all pages rendered under the @tabs slot.
Useful? React with 👍 / 👎.
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/sculptor/-/pipelines/2255694575 Status: Passed |
1 participant
Close #34