Skip to content

Add video fullscreen toggle feature using 'F' for new version of videos #1828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Vignesh9123
Copy link

PR Fixes:

  • Fullscreen toggle when user clicks F for new version of videos
  • This was already working on older version of videos that uses video-js but not on newer version that depends on iframe

Resolves #1822

  • I couldn't test it with a sample video as I was not able to get cdn url from akamai secure player
  • I tested it using a random embed iframe url and it works

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@Vignesh9123
Copy link
Author

@devsargam Please let me know if this fixes the issue using the original akamai video url, Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Add Fullscreen Toggle via 'F' Key Press
1 participant