deprecate incydr functionality and remove guides #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tora-kozic
reviewed
Mar 20, 2025
tora-kozic
reviewed
Mar 20, 2025
| == output.count("AffectedUserUID") | ||
| == 1 | ||
| ) | ||
| # def test_search_when_table_format_and_using_output_via_pager_only_includes_header_keys_once( |
There was a problem hiding this comment.
why is this commented out?
There was a problem hiding this comment.
The test broke with the changes because it is just reading all of the output, so the addition of a warning message caused it to miss its expected header. The header is still there properly, and I figured it was probably best not to spend time updating a test for functionality that we're deprecating and don't intend to update.
tora-kozic
approved these changes
Mar 20, 2025
I added a link to the dev portal in the deprecation text. |
jdullum
approved these changes
Mar 20, 2025
tora-kozic
approved these changes
Mar 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incydr functionality is deprecated in the code42cli. Users should use the Incydr CLI (available at https://developer.code42.com/) instead.
This PR also removes user guides that referred to deprecated functionality.